This repository was archived by the owner on Jul 8, 2023. It is now read-only.
Add 'Formal Tempai' strategy #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogachev-pa
force-pushed
the
formal_tempai
branch
from
d0899f7 to
4eb098e
Compare
Nihisil
reviewed
Aug 24, 2018
| else: | ||
| # having 2 or more doras and 2 shanten, let's go for formal | ||
| # tempai starting from 12th turn | ||
| return (self.player.round_step >= 12) |
| if self.player.ai.ukeire <= 16: | ||
| return True | ||
| elif self.player.ai.ukeire <= 28: | ||
| return (self.player.round_step >= 12) |
| elif self.player.ai.ukeire <= 28: | ||
| return (self.player.round_step >= 12) | ||
| else: | ||
| return (self.player.round_step >= 13) |
| return (self.player.round_step >= 13) | ||
| elif dora_count == 1: | ||
| if self.player.ai.ukeire <= 16: | ||
| return (self.player.round_step >= 12) |
| if self.player.ai.ukeire <= 16: | ||
| return (self.player.round_step >= 12) | ||
| elif self.player.ai.ukeire <= 28: | ||
| return (self.player.round_step >= 13) |
| elif self.player.ai.ukeire <= 28: | ||
| return (self.player.round_step >= 13) | ||
| else: | ||
| return (self.player.round_step >= 14) |
| return (self.player.round_step >= 14) | ||
| else: | ||
| if self.player.ai.ukeire <= 16: | ||
| return (self.player.round_step >= 13) |
| if self.player.ai.ukeire <= 16: | ||
| return (self.player.round_step >= 13) | ||
| else: | ||
| return (self.player.round_step >= 14) |
|
|
||
| # Now we move to 11th turn, we have 2 shanten and no doras, | ||
| # we should go for formal tempai | ||
| self.player.add_discarded_tile(Tile(0, True)) |
There was a problem hiding this comment.
Думаю дальше должна быть строка:
self.assertEqual(strategy.should_activate_strategy(), True)
Nihisil
reviewed
Aug 24, 2018
|
|
||
| # for 1 shanten we check number of doras and ukeire to determine | ||
| # correct time to go for formal tempai | ||
| if self.player.ai.previous_shanten == 1: |
There was a problem hiding this comment.
Ещё это дело вкуса, но я бы переписал все эти блоки без else. Мы делаем return из первого ифа, так что особо else тут не нужен.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.