Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

chore: added time-travel dungeon #165

Merged
merged 7 commits into from
Jun 24, 2021

Conversation

hkumar0132
Copy link
Collaborator

No description provided.

@welcome
Copy link

welcome bot commented Jun 22, 2021

Thanks for opening this pull request! Please check out our contributing guidelines.

Comment on lines 7 to 10




Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete these lines

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ming-tsai ming-tsai changed the title Added time-travel dungeon chore: added time-travel dungeon Jun 22, 2021
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hkumar0132,
Could you add your dungeon on this options

@ming-tsai ming-tsai added beginner Need more contributors documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-accepted Accepted by hacktoberfest, will marge later labels Jun 22, 2021
Comment on lines 49 to 52
{posts.map((post, index) => (
<CardGrid item key={index} post={post} xs={12} sm={6} md={3} />
))}
{posts.map((post, index) => {
console.log(post, index);
return <CardGrid item key={index} post={post} xs={12} sm={6} md={3} />
})}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollback this change and package-lock.json

@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hkumar0132
Copy link
Collaborator Author

Hey @ming-tsai I have made the changes. Let me know if any more changes required.

Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @hkumar0132 🎉🚀🥇

@ming-tsai ming-tsai merged commit 9f38ac8 into MakeContributions:master Jun 24, 2021
@welcome
Copy link

welcome bot commented Jun 24, 2021

Congrats on merging your first pull request! We here at MakeContributions are proud of you! 🎉🎉🎉🎉.
You are invited to be part of the team, the invitation link

@ming-tsai ming-tsai linked an issue Jun 25, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginner Need more contributors documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-accepted Accepted by hacktoberfest, will marge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants