Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Julia nightly + breaking-release #2534

Closed
wants to merge 47 commits into from
Closed

[Test] Julia nightly + breaking-release #2534

wants to merge 47 commits into from

Conversation

SimonDanisch
Copy link
Member

@SimonDanisch SimonDanisch commented Dec 29, 2022 •
edited
Loading

Benchmarks #2220 on julia nightly

SimonDanisch and others added 30 commits July 20, 2022 00:26
@SimonDanisch
don't use data_limits to figure out axis type (#1770)
83afc88 
* don't use data_limits to figure out axis type

* fix is2d

* fix tests

* fix heatmap

* fix remaining tests

* Update contours.jl

* fix comments
@SimonDanisch
fix 2d surfaces, add test (#1913)
d29f6d5
@SimonDanisch
[breaking] clean up conversion pipeline (#1810)
18a42e4 
* convert more orderly

* fix problems

* ok, we can't actually recursively convert

* the need for recursion

* fix conversions

* geometry improvements

* fix surface

* fix surface

* remove unused files

* fix heatmap with Intervals

* bring back nice errors, by introducing proper per plot convert targets

* fix plot

* fix tests

* reset runtests

* address review

* resurrect Grid and address last review comment

fix surface

fix tests
@SimonDanisch
improve default axis type (#1935)
bcecc07 
* don't use data_limits to figure out axis type (#1770)

* don't use data_limits to figure out axis type

* fix is2d

* fix tests

* fix heatmap

* fix remaining tests

* Update contours.jl

* fix comments

* fix 2d surfaces, add test (#1913)

* [breaking] clean up conversion pipeline (#1810)

* convert more orderly

* fix problems

* ok, we can't actually recursively convert

* the need for recursion

* fix conversions

* geometry improvements

* fix surface

* fix surface

* remove unused files

* fix heatmap with Intervals

* bring back nice errors, by introducing proper per plot convert targets

* fix plot

* fix tests

* reset runtests

* address review

* resurrect Grid and address last review comment

* fix surface

* fix tests

* less magic, clearer name

* fix remaining signatures, fix tests

* fix makie tests

* fix matrix_grid

* gotta remove flat surface from WGLMakie tests :(

* fix merge conflicts vscode didn't show
@SimonDanisch
Clean up Attribute constructor & indexing code (#1930)
ee2994b 
* don't use data_limits to figure out axis type (#1770)

* don't use data_limits to figure out axis type

* fix is2d

* fix tests

* fix heatmap

* fix remaining tests

* Update contours.jl

* fix comments

* fix 2d surfaces, add test (#1913)

* [breaking] clean up conversion pipeline (#1810)

* convert more orderly

* fix problems

* ok, we can't actually recursively convert

* the need for recursion

* fix conversions

* geometry improvements

* fix surface

* fix surface

* remove unused files

* fix heatmap with Intervals

* bring back nice errors, by introducing proper per plot convert targets

* fix plot

* fix tests

* reset runtests

* address review

* resurrect Grid and address last review comment

* clean up attribute code / easier compilation

* qualify AbstractObservable

* speed improvements

* don't use data_limits to figure out axis type (#1770)

* don't use data_limits to figure out axis type

* fix is2d

* fix tests

* fix heatmap

* fix remaining tests

* Update contours.jl

* fix comments

* fix 2d surfaces, add test (#1913)

* [breaking] clean up conversion pipeline (#1810)

* convert more orderly

* fix problems

* ok, we can't actually recursively convert

* the need for recursion

* fix conversions

* geometry improvements

* fix surface

* fix surface

* remove unused files

* fix heatmap with Intervals

* bring back nice errors, by introducing proper per plot convert targets

* fix plot

* fix tests

* reset runtests

* address review

* resurrect Grid and address last review comment

* don't use data_limits to figure out axis type (#1770)

* don't use data_limits to figure out axis type

* fix is2d

* fix tests

* fix heatmap

* fix remaining tests

* Update contours.jl

* fix comments

* fix 2d surfaces, add test (#1913)

* [breaking] clean up conversion pipeline (#1810)

* convert more orderly

* fix problems

* ok, we can't actually recursively convert

* the need for recursion

* fix conversions

* geometry improvements

* fix surface

* fix surface

* remove unused files

* fix heatmap with Intervals

* bring back nice errors, by introducing proper per plot convert targets

* fix plot

* fix tests

* reset runtests

* address review

* resurrect Grid and address last review comment

* fix surface

* fix tests

* remove some boxes

fix merge

fix contourf
@SimonDanisch
switch to using untyped PlotObject
07c45f7
@SimonDanisch
bring back overrides
5751f19
@SimonDanisch
try to recover some caching
b5eab95
@SimonDanisch
fix text problems
9b334ff
@SimonDanisch
somewhat fix glmakie
c00c412
@SimonDanisch
fix Text bb + GLMakie scatter
fbea2b8
@SimonDanisch
fix plotkey when precompiling
4467969
@SimonDanisch
don't overwrite plot object
b50943e
@SimonDanisch
get things to compile
386d6ad 
get benchmark going
@SimonDanisch
work off GeometryBasics#sd/simple-mesh
32449f1
@SimonDanisch
fix CairoMakie tests
a56a068
@SimonDanisch
remove unecessary nospecialize
c097d57
@SimonDanisch
start fixing GLMakie
a7effbc
@SimonDanisch
move empty!(FONT_CACHE)
011c590
@SimonDanisch
fix all the tests
d3e27e6
@SimonDanisch
checkout the right packages
3d6c545
@SimonDanisch
remove not yet supported precompiles
b57a9da
@SimonDanisch
don't use data_limits to figure out axis type (#1770)
9c8ea1e 
* don't use data_limits to figure out axis type

* fix is2d

* fix tests

* fix heatmap

* fix remaining tests

* Update contours.jl

* fix comments
@SimonDanisch
fix 2d surfaces, add test (#1913)
e81e497
@SimonDanisch
[breaking] clean up conversion pipeline (#1810)
780264d 
* convert more orderly

* fix problems

* ok, we can't actually recursively convert

* the need for recursion

* fix conversions

* geometry improvements

* fix surface

* fix surface

* remove unused files

* fix heatmap with Intervals

* bring back nice errors, by introducing proper per plot convert targets

* fix plot

* fix tests

* reset runtests

* address review

* resurrect Grid and address last review comment

fix surface

fix tests
@SimonDanisch
improve default axis type (#1935)
5f9ea57 
* don't use data_limits to figure out axis type (#1770)

* don't use data_limits to figure out axis type

* fix is2d

* fix tests

* fix heatmap

* fix remaining tests

* Update contours.jl

* fix comments

* fix 2d surfaces, add test (#1913)

* [breaking] clean up conversion pipeline (#1810)

* convert more orderly

* fix problems

* ok, we can't actually recursively convert

* the need for recursion

* fix conversions

* geometry improvements

* fix surface

* fix surface

* remove unused files

* fix heatmap with Intervals

* bring back nice errors, by introducing proper per plot convert targets

* fix plot

* fix tests

* reset runtests

* address review

* resurrect Grid and address last review comment

* fix surface

* fix tests

* less magic, clearer name

* fix remaining signatures, fix tests

* fix makie tests

* fix matrix_grid

* gotta remove flat surface from WGLMakie tests :(

* fix merge conflicts vscode didn't show
@SimonDanisch
Clean up Attribute constructor & indexing code (#1930)
dd23e95 
* don't use data_limits to figure out axis type (#1770)

* don't use data_limits to figure out axis type

* fix is2d

* fix tests

* fix heatmap

* fix remaining tests

* Update contours.jl

* fix comments

* fix 2d surfaces, add test (#1913)

* [breaking] clean up conversion pipeline (#1810)

* convert more orderly

* fix problems

* ok, we can't actually recursively convert

* the need for recursion

* fix conversions

* geometry improvements

* fix surface

* fix surface

* remove unused files

* fix heatmap with Intervals

* bring back nice errors, by introducing proper per plot convert targets

* fix plot

* fix tests

* reset runtests

* address review

* resurrect Grid and address last review comment

* clean up attribute code / easier compilation

* qualify AbstractObservable

* speed improvements

* don't use data_limits to figure out axis type (#1770)

* don't use data_limits to figure out axis type

* fix is2d

* fix tests

* fix heatmap

* fix remaining tests

* Update contours.jl

* fix comments

* fix 2d surfaces, add test (#1913)

* [breaking] clean up conversion pipeline (#1810)

* convert more orderly

* fix problems

* ok, we can't actually recursively convert

* the need for recursion

* fix conversions

* geometry improvements

* fix surface

* fix surface

* remove unused files

* fix heatmap with Intervals

* bring back nice errors, by introducing proper per plot convert targets

* fix plot

* fix tests

* reset runtests

* address review

* resurrect Grid and address last review comment

* don't use data_limits to figure out axis type (#1770)

* don't use data_limits to figure out axis type

* fix is2d

* fix tests

* fix heatmap

* fix remaining tests

* Update contours.jl

* fix comments

* fix 2d surfaces, add test (#1913)

* [breaking] clean up conversion pipeline (#1810)

* convert more orderly

* fix problems

* ok, we can't actually recursively convert

* the need for recursion

* fix conversions

* geometry improvements

* fix surface

* fix surface

* remove unused files

* fix heatmap with Intervals

* bring back nice errors, by introducing proper per plot convert targets

* fix plot

* fix tests

* reset runtests

* address review

* resurrect Grid and address last review comment

* fix surface

* fix tests

* remove some boxes

fix merge

fix contourf
@SimonDanisch
don't run push CI
0cb2a65
@SimonDanisch
Merge branch 'sd/light-geometrybasics' into breaking-release
141ae25
@SimonDanisch
fix merge bugs
fd7bf22
@MakieBot
Copy link
Collaborator

MakieBot commented Dec 29, 2022 •
edited
Loading

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 11.85s (11.67, 12.01) 0.11+- 453.52ms (445.84, 460.53) 6.23+- 777.84ms (762.44, 811.16) 16.27+- 18.15ms (17.61, 18.48) 0.30+- 85.93ms (84.66, 87.32) 1.04+-
master 14.65s (14.49, 14.82) 0.12+- 769.30ms (757.53, 789.17) 10.83+- 736.71ms (726.15, 744.15) 6.62+- 25.38ms (24.74, 26.02) 0.45+- 93.75ms (92.24, 95.39) 1.06+-
evaluation -23.63%, -2.8s faster✅ (-24.07d, 0.00p, 0.12std) -69.63%, -315.78ms faster✅ (-35.75d, 0.00p, 8.53std) +5.29%, 41.13ms slower❌ (3.31d, 0.00p, 11.44std) -39.79%, -7.22ms faster✅ (-19.03d, 0.00p, 0.37std) -9.11%, -7.83ms faster✅ (-7.45d, 0.00p, 1.05std)
CairoMakie 10.89s (10.82, 10.95) 0.05+- 581.73ms (560.50, 606.37) 16.13+- 356.64ms (347.14, 360.19) 4.52+- 28.81ms (28.41, 29.23) 0.25+- 6.68ms (6.54, 6.76) 0.07+-
master 15.49s (15.16, 15.83) 0.22+- 964.63ms (941.98, 981.53) 13.26+- 367.62ms (352.47, 384.26) 11.55+- 42.81ms (41.66, 44.07) 0.95+- 18.69ms (18.49, 18.93) 0.16+-
evaluation -42.33%, -4.61s faster✅ (-28.83d, 0.00p, 0.14std) -65.82%, -382.91ms faster✅ (-25.94d, 0.00p, 14.69std) -3.08%, -10.98ms faster ✓ (-1.25d, 0.05p, 8.04std) -48.61%, -14.0ms faster✅ (-20.17d, 0.00p, 0.60std) -179.79%, -12.01ms faster✅ (-99.79d, 0.00p, 0.11std)
WGLMakie – – – – –
master – – – – –
evaluation – – – – –

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonDanisch @MakieBot