Skip to content

Conversation

stumitchell
Copy link
Contributor

In progress, adding the pull request so I can get travis working

@Malabarba
Copy link
Owner

Nice. Thanks for taking the time to do this.
Let me know when travis stops complaining, and don't worry about the redundancy-check above.

@stumitchell
Copy link
Contributor Author

Also note I had to remove the tests for 1.5.0 1.6.0 compatibility
Let me know if this is an issue
I think it is important to share tests but we can only do that with reader conditionals which are only available in 1.7.0

@stumitchell stumitchell force-pushed the feature/clojurescript-support branch from 03855dc to 6c2eaa1 Compare November 26, 2015 21:04
@stumitchell
Copy link
Contributor Author

BTW travis has stopped complaining

Malabarba added a commit that referenced this pull request Dec 7, 2015
@Malabarba Malabarba merged commit 59c0d19 into Malabarba:master Dec 7, 2015
@Malabarba
Copy link
Owner

Awesome! Thanks again for this.
Sorry for leaving this for so long, I hadn't noticed travis was green.

@stumitchell
Copy link
Contributor Author

Any plans to do a clojars release?
I'll just to a private branch in the meantime

@stumitchell
Copy link
Contributor Author

oh for completeness I will do a slight change to -assoc I'll put that in here too.

@Malabarba
Copy link
Owner

I was just about to push to clojars
If you have another change, I can hold the release while you make a PR.

@stumitchell
Copy link
Contributor Author

Cool will do it after my meeting here thanks

@stumitchell
Copy link
Contributor Author

just checked and the -assoc code already did what it should do. Feel free to release

@Malabarba
Copy link
Owner

Ok. I'll push when I get home.

@stumitchell
Copy link
Contributor Author

Still waiting on the clojars :-( will it be 1.1?
let me know if you will take a while as I can simply depend on a clojars version under my own name.

@Malabarba
Copy link
Owner

Really sorry about this! I'm undergoing a reallocation, so my schedules and organisation are a mess right now.
Feel free to push this to your own clojar username. It might take me a few more days to do it myself.

@Malabarba
Copy link
Owner

Ok. I managed to find a free minute and deployed to clojars today.
Version 1.1

@stumitchell
Copy link
Contributor Author

Thanks a lot I can merge it into my work project now.
On 12 Dec 2015 10:13 a.m., "Artur Malabarba" notifications@github.com
wrote:

Ok. I managed to find a free minute and deployed to clojars today.
Version 1.1


Reply to this email directly or view it on GitHub
#3 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants