Skip to content

Conversation

movitto
Copy link
Contributor

@movitto movitto commented Mar 23, 2016

No description provided.

@chessbyte
Copy link
Member

@movitto Thanks for the enhancement. Can you add a spec, please, for this new method?

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 96.743% when pulling f08ad55 on movitto:attribute_offset into fbbb149 on ManageIQ:master.

@coveralls
Copy link

coveralls commented Mar 24, 2016

Coverage Status

Coverage increased (+0.3%) to 99.003% when pulling 9bc1411 on movitto:attribute_offset into fbbb149 on ManageIQ:master.

@miq-bot
Copy link
Member

miq-bot commented Mar 24, 2016

Checked commits movitto/binary_struct@61fbb0b~...9bc1411 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 4 offenses detected

lib/binary_struct.rb

@chessbyte
Copy link
Member

@Fryguy please review

@miq-bot miq-bot added the stale label Jun 12, 2020
@miq-bot
Copy link
Member

miq-bot commented Jun 12, 2020

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

@chessbyte chessbyte closed this Jun 22, 2020
@chessbyte chessbyte reopened this Jun 22, 2020
@chessbyte chessbyte closed this Jun 22, 2020
@chessbyte chessbyte reopened this Jun 22, 2020
@Fryguy Fryguy merged commit cdb50ec into ManageIQ:master Jun 22, 2020
@Fryguy Fryguy self-assigned this Jun 22, 2020
@Fryguy Fryguy removed the stale label Jun 22, 2020
@movitto
Copy link
Contributor Author

movitto commented Jun 22, 2020

Huzzah... closure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants