Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

developer_setup.md: fix some steps and deps - tested on clean Centos 7.1 #102

Merged
merged 1 commit into from
Feb 16, 2016

Conversation

cben
Copy link
Contributor

@cben cben commented Feb 14, 2016

A couple "Configure PostgreSQL" commands didn't work as-is; clarified where password is asked.

rbenv install 2.2.0 gives an obscure linker warning fixed by having libffi-devel [https://github.com/rbenv/ruby-build/issues/690].
Their FAQ actually suggests more [https://github.com/rbenv/ruby-build/wiki#suggested-build-environment]:

dnf install -y gcc bzip2 openssl-devel libyaml-devel libffi-devel readline-devel zlib-devel gdbm-devel ncurses-devel

but bzip2 libffi-devel readline-devel (plus openssl-devel we already listed) were enough to build.
(not sure if these are relevant for rvm/ruby-install, or for Ruby 2.2.1+, but as long as guide says "required version is 2.2", it should work with 2.2.0)

nodejs is the obvious option to satisfy ExecJS, otherwise sprockets/es6 gem refuses to load.
(also nodejs + npm needed for self-service tests - but these are separate repo now, right?)

A couple "Configure PostgreSQL" commands didn't work as-is; clarified where password is asked.

rbenv install 2.2.0 gives an obscure warning fixed by having libffi-devel [rbenv/ruby-build#690].
Their FAQ actually suggests more [https://github.com/rbenv/ruby-build/wiki#suggested-build-environment]:
    dnf install -y gcc bzip2 openssl-devel libyaml-devel libffi-devel readline-devel zlib-devel gdbm-devel ncurses-devel
but `bzip2 libffi-devel readline-devel` 3 were enough to build.

nodejs is the obvious option to satisfy ExecJS, otherwise sprockets/es6 gem refuses to load.
@cben
Copy link
Contributor Author

cben commented Feb 14, 2016

BTW, http://manageiq.org/documentation/development/developer_setup/ is already out of date wrt to this file.

@matthewd
Copy link
Contributor

not sure if these are relevant for rvm/ruby-install, or for Ruby 2.2.1+, but as long as guide says "required version is 2.2", it should work with 2.2.0

"2.2" != "2.2.0"; you definitely shouldn't be using 2.2.0 -- more recent 2.2.x releases contain security fixes.

@cben
Copy link
Contributor Author

cben commented Feb 16, 2016

Fair enough, I'm a total ruby newbie.
Do you want the guide to say something like "Required/recommended ruby version is 2.2.4"? Or "latest release of 2.2.x"? (consider this guide is not only for core devs, it's also "how do I run this from source" for everyone).

Anyway, re-tested with 2.2.4, works without libffi-devel and with the other changes.

kbrock added a commit that referenced this pull request Feb 16, 2016
developer_setup.md: fix some steps and deps - tested on clean Centos 7.1
@kbrock kbrock merged commit f493dd8 into ManageIQ:master Feb 16, 2016
carbonin added a commit to carbonin/guides that referenced this pull request Mar 23, 2016
Before, this command would have overwritten the entire pg_hba.conf
file if you did not have a matching line.
With the -a flag tee will append the line to the end of the file
rather than truncating it.

Introduced in ManageIQ#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants