Added method to update the IP address for a particular hostname #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/linux_admin/hosts.rb
Outdated
There was a problem hiding this comment.
Prefer the positive case if line_num
carbonin
force-pushed
the
add_update_ip_for_hostname_to_hosts
branch
from
dc1216e to
f4edbbe
Compare
|
Checked commit carbonin@f4edbbe with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
Determined that this change is not necessary after discussion with @bdunne |
|
The assumed use case was:
Setting IP should have nothing to do with the hosts file.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bdunne Please review
https://trello.com/c/rWKh4KQs