Skip to content

Don't extend self to set up the logger #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2015
Merged

Don't extend self to set up the logger #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/linux_admin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,12 @@

module LinuxAdmin
extend Common
extend self

attr_writer :logger
class << self
attr_writer :logger
end

def logger
def self.logger
@logger ||= NullLogger.new
end
end
2 changes: 2 additions & 0 deletions lib/linux_admin/common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

module LinuxAdmin
module Common
include Logging

BIN_DIRS = %w(/bin /sbin /usr/bin /usr/sbin /usr/local/bin /usr/local/sbin)

def cmd(name)
Expand Down
2 changes: 0 additions & 2 deletions lib/linux_admin/rpm.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
module LinuxAdmin
class Rpm < Package
extend Logging

def self.rpm_cmd
cmd(:rpm)
end
Expand Down