Allow NetworkInterface creation without a config file #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow a user on a Red Hat system to use the "getter" methods defined in network_interface.rb even if they don't have a config file corresponding to the given interface name. To do this we instantiate a NetworkInterfaceGeneric object if the file doesn't exist rather than a NetworkInterfaceRH instance. Fixes ManageIQ#139
|
Checked commit carbonin@ca3daa6 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
👍 LGTM @Fryguy Any concerns? |
Fryguy
added a commit
that referenced
this pull request
Oct 27, 2015
…t_config_file Allow NetworkInterface creation without a config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow a user on a Red Hat system to use the "getter" methods defined in
network_interface.rbeven if they don't have a config file corresponding to the given interface name.To do this we instantiate a
NetworkInterfaceGenericobject if the file doesn't exist rather than aNetworkInterfaceRHinstance.@abonas @bdunne @Fryguy
Fixes #139