Dont fail when only IPv6 addresses are returned by ip addr show
#141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
changed the title
ip addr showip addr show
|
Checked commits carbonin/linux_admin@29fe376~...1637369 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
bdunne
added a commit
that referenced
this pull request
Nov 30, 2015
Dont fail when only IPv6 addresses are returned by `ip addr show`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the regex in
NetworkInterface#parse_ip4would also match ipv6 addresses.This would cause an issue when only ipv6 addresses were returned by the
ip addr showcommand.This problem was masked by the fact that ipv4 addresses are returned first in the output and
detectreturns the first matching line.@bdunne