Added a method to set the canonical hostname in /etc/hosts
#144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM |
carbonin
force-pushed
the
differentiate_between_fqdn_and_hostname_aliases
branch
from
a13914a to
e7738ef
Compare
|
Checked commit carbonin@e7738ef with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 lib/linux_admin/hosts.rb
spec/hosts_spec.rb
|
|
What do you think about this @bdunne ? |
|
LGTM !! |
bdunne
added a commit
that referenced
this pull request
Dec 4, 2015
…hostname_aliases Added a method to set the canonical hostname in `/etc/hosts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the old
#update_entryto the private method#add_nameand aliased#update_entryfor backwards compatibility.@bdunne @abellotti
Fixes #143
https://bugzilla.redhat.com/show_bug.cgi?id=1286830