Added a new line at the end of /etc/hosts #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM!! 👍 |
|
@abellotti Was this causing a specific issue for you or just something you noticed while testing other hostname-related stuff? |
|
noticed it while testing IPA with appliance_console. I usually add the ipa server entry at the end of the host file and noticed its NL was gone after setting the hostname via appliance_console. |
|
👍 LGTM |
gtanzillo
added a commit
that referenced
this pull request
Dec 1, 2015
Added a new line at the end of /etc/hosts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was no new line character at the end of the file after we save it.
This would cause a problem if someone tried to append a line to the file in some way other than using this class.
@bdunne @abellotti