Refactor and add SubscriptionManager.organizations #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chessbyte I agree and have renamed the method |
There was a problem hiding this comment.
This could just be an index_by call...
processed_data.index_by { |d| d[index_key] }which means you probably don't need a whole method, since the callers will be clear enough.
|
@Fryguy I removed the indexing method and used index_by, moved command into #organizations, and renamed #parse_output as suggested |
Fryguy
added a commit
that referenced
this pull request
Aug 8, 2013
…nManager_list_orgs Refactor and add SubscriptionManager.organizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.