-
Notifications
You must be signed in to change notification settings - Fork 30
Add #subscribed? method and auto-attach to #subscribe #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandondunne Use <<
instead of +=
. However, you could probably just add a {"--auto" => nil}
to the params and get the same effect. Is there an ordering problem that you need to add this first?
The last commit says |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this return the same thing as SubscriptionManager#subscribed_products ? I would think both methods should return the same thing for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More specifically, I noticed in the specs, that one returns an array of string, and the other an array of ids...I'm assuming that's considered the "same thing", but does the caller know to present those differently. I guess my overall question is what is the use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They both return an array. The two sources don't provide any common values. This is the closest that it can get.
Add #subscribed? method and auto-attach to #subscribe
No description provided.