Skip to content

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Sep 19, 2013

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling dc97d19 on brandondunne:subscribing_issues into 789b2bd on ManageIQ:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d918082 on brandondunne:subscribing_issues into 789b2bd on ManageIQ:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling d918082 on brandondunne:subscribing_issues into 789b2bd on ManageIQ:master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandondunne Use << instead of +=. However, you could probably just add a {"--auto" => nil} to the params and get the same effect. Is there an ordering problem that you need to add this first?

@Fryguy
Copy link
Member

Fryguy commented Sep 19, 2013

The last commit says add #subscribed? but it looks like you removed subscribed?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling dc51e45 on brandondunne:subscribing_issues into 789b2bd on ManageIQ:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 2664411 on brandondunne:subscribing_issues into 789b2bd on ManageIQ:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 2664411 on brandondunne:subscribing_issues into 789b2bd on ManageIQ:master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this return the same thing as SubscriptionManager#subscribed_products ? I would think both methods should return the same thing for consistency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More specifically, I noticed in the specs, that one returns an array of string, and the other an array of ids...I'm assuming that's considered the "same thing", but does the caller know to present those differently. I guess my overall question is what is the use case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They both return an array. The two sources don't provide any common values. This is the closest that it can get.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cec02de on brandondunne:subscribing_issues into 789b2bd on ManageIQ:master.

Fryguy added a commit that referenced this pull request Sep 20, 2013
Add #subscribed? method and auto-attach to #subscribe
@Fryguy Fryguy merged commit ba1cc0e into ManageIQ:master Sep 20, 2013
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) when pulling 7a98d84 on brandondunne:subscribing_issues into 789b2bd on ManageIQ:master.

@bdunne bdunne deleted the subscribing_issues branch September 20, 2013 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants