Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.1: Specify vim classes as permitted in test #892

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Dec 18, 2023

Depends on the interface to add these classes to the list in this PR:
ManageIQ/manageiq#22698
@jrafanie jrafanie added the test label Dec 18, 2023
@agrare agrare self-assigned this Dec 18, 2023
jrafanie added a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Dec 18, 2023
@jrafanie jrafanie added the wip label Dec 18, 2023
@miq-bot
Copy link
Member

miq-bot commented Dec 18, 2023

Checked commit jrafanie@dcb2784 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@jrafanie
Copy link
Member Author

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Dec 18, 2023
@agrare
Copy link
Member

agrare commented Dec 18, 2023

Cross repo is green, merging on red ManageIQ/manageiq-cross_repo-tests#835

@agrare agrare merged commit 4db9814 into ManageIQ:master Dec 18, 2023
2 of 3 checks passed
@jrafanie jrafanie deleted the ruby31_specify_permitted_classes_in_test_for_vim_classes branch December 18, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants