Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving testing gems capybara, jasmine over from main repo #1008

Closed
wants to merge 1 commit into from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Apr 11, 2017

These tests depend upon jasmine for javascript
and capybara for integration tests

Moving them closer to the source

Please let me know if no one uses jasmine.

These tests depend upon jasmine for javascript
and capybara for integration tests

Moving them closer to the source
@kbrock
Copy link
Member Author

kbrock commented Apr 13, 2017

kicking

@kbrock kbrock reopened this Apr 13, 2017
@miq-bot
Copy link
Member

miq-bot commented Apr 13, 2017

Checked commit kbrock@0f09777 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. ⭐

@himdel
Copy link
Contributor

himdel commented Apr 13, 2017

Definitely using jasmine, but I had no idea we're using capybara :).

Just one thing @kbrock .. this makes us require jasmine and capybara always, doesn't it?
Looks like previously capybara would only get required in test env, and jasmine only via ui-classic rake. (Jasmine should only be needed for rake spec:javascript and rake environment jasmine.)

@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2017

This pull request is not mergeable. Please rebase and repush.

@himdel
Copy link
Contributor

himdel commented Apr 25, 2017

Oh, sorry @kbrock, completely forgot about your PR and now jasmine broke so I did #1148.

So.. you sure we're using Capybara? The only sign of it is that require in test.rb, and then one function that's never called in a spec helper..

... EDIT: ok, never mind, we do..

have_text, have_selector, have_xpath are used in specs (167 failures if not there :))

So yup, we need capybara too :)

@kbrock
Copy link
Member Author

kbrock commented May 2, 2017

<3 thanks martin

@kbrock kbrock closed this May 3, 2017
@kbrock kbrock deleted the gem_tests branch May 3, 2017 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants