Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sporadic test failure #2592

Merged
merged 3 commits into from
Nov 1, 2017
Merged

Fix sporadic test failure #2592

merged 3 commits into from
Nov 1, 2017

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Nov 1, 2017

  • Sporadic failure due to database ordering issue
  • Don't use static IDs because we should be testing with a random region number
  • Ensure that the other ID does not exist

@bdunne
Copy link
Member Author

bdunne commented Nov 1, 2017

@Fryguy @jrafanie Please review.
@miq-bot add_labels gaprindashvili/yes, test, sporadic_failure

@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2017

@bdunne Cannot apply the following label because they are not recognized: sporadic_failure

@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2017

Checked commits bdunne/manageiq-ui-classic@15095b5~...1b9fc45 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

jrafanie
jrafanie approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@martinpovolny martinpovolny merged commit 7a133b7 into ManageIQ:master Nov 1, 2017
@martinpovolny martinpovolny self-assigned this Nov 1, 2017
@martinpovolny martinpovolny added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 1, 2017
@bdunne bdunne deleted the fix_sporadic_test_failure branch November 1, 2017 18:57
simaishi pushed a commit that referenced this pull request Nov 6, 2017
@martinpovolny @simaishi
Merge pull request #2592 from bdunne/fix_sporadic_test_failure
c69308d 
Fix sporadic test failure
(cherry picked from commit 7a133b7)
@simaishi
Copy link
Contributor

simaishi commented Nov 6, 2017

Gaprindashvili backport details:

$ git log -1
commit c69308d0a659d3cf610e3276a52bf1ebd962f866
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Wed Nov 1 19:51:49 2017 +0100

    Merge pull request #2592 from bdunne/fix_sporadic_test_failure
    
    Fix sporadic test failure
    (cherry picked from commit 7a133b74327b2e917a2ca3ab21250ec33e405c92)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@martinpovolny martinpovolny

Labels
gaprindashvili/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdunne @miq-bot @simaishi @jrafanie @martinpovolny