Drop haml_lint to avoid deprecated haml constant #18886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to ManageIQ#18868 This a development dependency that can be added individually for anyone who needs it. The problem is `hamlit` tries to require `haml` in the template [here](https://github.com/k0kubun/hamlit/blob/94b14839cd42e8b70715ba7c0caf18c2c47ec67a/lib/hamlit/template.rb#L8) and because we have `haml` in our dependency tree due to `haml_lint` (for dev), it will be able to require it. Because this causes the rails 5.1 deprecated constant to be loaded, we get this deprecation warning: ``` DEPRECATION WARNING: ActionView::Template::Handlers::Erubis is deprecated and will be removed from Rails 5.2. Switch to ActionView::Template::Handlers::ERB::Erubi instead. (called from <top (required)> at /Users/joerafaniello/Code/manageiq/config/application.rb:31) ``` Since haml_lint doesn't have a version that forces haml >= 5.0 (where this is fixed), we have to either: * add haml it as a direct dependency so we can say >= 5.0 (like this PR) * drop haml_lint entirely (so haml doesn't get in the dependency tree) * ignore/live with this warning whenever you run tests or rails server/console/etc. This commit takes option 2, drop haml_lint since it's a dev dependency that can easily be added in bundler.d directory for any developers who want it.
This was referenced Jun 18, 2019
|
Checked commit jrafanie@c2150da with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
This was referenced Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #18868
This a development dependency that can be added individually for anyone
who needs it.
The problem is
hamlittries to requirehamlin the template hereand because we have
hamlin our dependency tree due tohaml_lint(for dev), it will be able to require it.Because this causes the rails 5.1 deprecated constant to be loaded, we get this deprecation warning:
Since haml_lint doesn't have a version that forces haml >= 5.0 (where this is fixed), we have to either:
This commit takes option 2, drop haml_lint since it's a dev dependency
that can easily be added in bundler.d directory for any developers who want it.