Skip to content

Avoided using deprecated get_points method and fixed :class:~.OpenGLPMPoint color #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2021

Conversation

k4pran
Copy link
Collaborator

@k4pran k4pran commented Sep 5, 2021

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

I noticed that there were some cases where the deprecated get_points() was being used, and color was only using the default so this PR fixes those.

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@k4pran k4pran added pr:bugfix Bug fix for use in PRs solving a specific issue:bug pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! labels Sep 5, 2021
Copy link
Member

@hydrobeam hydrobeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naveen521kk naveen521kk enabled auto-merge (squash) September 6, 2021 09:34
@naveen521kk naveen521kk merged commit 58092a7 into ManimCommunity:main Sep 6, 2021
@naveen521kk naveen521kk changed the title Avoid using deprecated get_points and fix :class:~.OpenGLPMPoint color Avoid using deprecated get_points and fix :class:~.OpenGLPMPoint color Sep 6, 2021
@behackl behackl changed the title Avoid using deprecated get_points and fix :class:~.OpenGLPMPoint color Avoided using deprecated get_points method and fixed :class:~.OpenGLPMPoint color Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants