Improved setting of OpenGL colors #2111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
Fixes #2087
In migrating tests from cairo to opengl some tests were failing due to
fill_color
,stroke_color
and their respective opacities not being set. The background_color was also always being set from config, so I made it a property to make it easier to change without changing the config.After these changes I could run the tests for color with opengl and added some new ones for fill and stroke
test.mp4
This also makes it more consistent with cairo with the exception of
background-opacity
. I couldn't set background opacity for opengl, and from what I can tell it isn't trivial to do.Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist