Skip to content

Fixed infinite loop in OpenGL BackgroundRectangle.get_color() #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Fixed infinite loop in OpenGL BackgroundRectangle.get_color() #3732

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41cbd1f
fix opengl bgrectangle: changed get_colors() and added fill_opacity i…
camburd2 Apr 27, 2024
8681d45
Merge branch 'main' into fix_bgrectangle_opengl_bug
chopan050 Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion manim/mobject/opengl/opengl_vectorized_mobject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ def match_style(self, vmobject, recurse=True):
vmobject_style = vmobject.get_style()
if config.renderer == RendererType.OPENGL:
vmobject_style["stroke_width"] = vmobject_style["stroke_width"][0][0]
vmobject_style["fill_opacity"] = self.get_fill_opacity()
self.set_style(**vmobject_style, recurse=False)
if recurse:
# Does its best to match up submobject lists, and
Expand Down Expand Up @@ -405,7 +406,7 @@ def get_stroke_opacity(self):
return self.get_stroke_opacities()[0]

def get_color(self):
if self.has_stroke():
if not self.has_fill():
return self.get_stroke_color()
return self.get_fill_color()

Expand Down