Simplify the function remove_invisible_chars in text_mobject.py

[henrikmidtiby]

Overview: What does this pull request change?

This PR implements a small refactoring suggested by @chopan050 in text_mobject.py.
#4381 (comment)

The change simplifies the code layout so it is easier for mortals to understand.

Reviewer Checklist

• The PR title is descriptive enough for the changelog, and the PR is labeled correctly
• If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
• If applicable: newly added functions and classes are tested

[behackl]

Just FYI, with #4392 the code-branch of this function is no longer needed at all. (The way it is implemented right now is actually also incompatible with the reworked Code mobject.)

[chopan050]

Just FYI, with #4392 the code-branch of this function is no longer needed at all. (The way it is implemented right now is actually also incompatible with the reworked Code mobject.)

Thanks for the info, Benjamin! I didn't even realize that Code no longer has a code attribute.

With this new information, @henrikmidtiby:

• since the Code branch does not apply anymore, because the invisible Dots would already be removed in the code with #4392, and
• the Text branch does not make much sense (doing mobject = mobject[:] only transforms the Text into a VGroup, but the submobjects are the same and it does not affect the subsequent code),

I would say that remove_invisible_chars() should not really have any of those branches. In that case, it would only do the logic we wanted to move into exclude_dots_from_mobject(). We might as well delete the latter function and move all of its logic back into remove_invisible_chars():

def remove_invisible_chars(mobject: SVGMobject) -> VGroup:
    mobject_without_dots = VGroup()
    if isinstance(mobject[0], VGroup):
        for submob in mobject:
            mobject_without_dots.add(VGroup(k for k in submob if not isinstance(k, Dot)))
    else:
        mobject_without_dots.add(*(k for k in mobject if not isinstance(k, Dot)))
    return mobject_without_dots

[chopan050]

Thanks!