removed keywords from -r flag #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging |
|
Well. I think we've got a problem to discuss, about what our command line paradigm is gonna be. I'll make an issue on that, stay tuned. |
|
Alright, brought it up in #65 |
|
Why are we removing this? This could be a nice feature for people who want to specify resolution. |
|
In short the reason why we consider removing this is because it's redundant with other commands. |
XorUnison
approved these changes
May 22, 2020
|
We had agreed upon adding this in order to add flexibility for more resolution presets in the future should we need it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the possibility to add keywords like "
medium", "low" etc... from the-rflag since you can do exactly the same but with for example-lfor"low"or--high_quality.