Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.0.5 #1066

Merged
merged 7 commits into from
Apr 7, 2023
Merged

Release v4.0.5 #1066

merged 7 commits into from
Apr 7, 2023

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Apr 6, 2023

Signed-off-by: Adam Reif Garandor@manta.network## Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Adam Reif added 3 commits April 6, 2023 14:14
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor self-assigned this Apr 6, 2023
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime L-skip Log: Will be skipped on changelog generation labels Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

Signed-off-by: Adam Reif <Garandor@manta.network>
Copy link
Contributor Author

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weights are quite a bit larger. benchmark rerun here: https://github.com/Manta-Network/Manta/actions/runs/4632446946/attempts/2

fixed the weight diffs

Adam Reif added 3 commits April 6, 2023 18:00
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor marked this pull request as ready for review April 7, 2023 04:45
@Garandor
Copy link
Contributor Author

Garandor commented Apr 7, 2023

One TBD for this release is manta re-benchmarking.
We'll most likely not upgrade manta until v4.0.6 anyway so i'll leave this to followup issue #1039 along with the testnet (also manta is empty for now anyway)

@Garandor Garandor merged commit 33a35f5 into manta Apr 7, 2023
@Garandor Garandor deleted the release-v4.0.5 branch April 7, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants