-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor manta genesis files, add manta-testnet
#1067
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-local Signed-off-by: Adam Reif <Garandor@manta.network>
… the file in the ansible repo) Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
added
C-enhancement
Category: An issue proposing an enhancement or a PR with one
A-manta
Area: Issues and PRs related to the Manta Runtime
C-cleanup
Category: Issues documenting cleanup or PRs that clean code up
A-development
Area: Development Resources and Upgrades
L-added
Log: Issues and PRs related to addition
labels
Apr 7, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
|
Garandor
requested review from
zqhxuyuan,
Dengjianping,
ghzlatarev and
ferrell-code
April 10, 2023 20:22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, looks good
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
ferrell-code
approved these changes
Apr 11, 2023
ghzlatarev
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-development
Area: Development Resources and Upgrades
A-manta
Area: Issues and PRs related to the Manta Runtime
C-cleanup
Category: Issues documenting cleanup or PRs that clean code up
C-enhancement
Category: An issue proposing an enhancement or a PR with one
L-added
Log: Issues and PRs related to addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same style can be used to clean up calamari, which is left as an exercise to the reader.
Signed-off-by: Adam Reif Garandor@manta.network
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
,A-dolphin
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.