Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor manta genesis files, add manta-testnet #1067

Merged
merged 9 commits into from
Apr 13, 2023

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Apr 7, 2023

Description

Same style can be used to clean up calamari, which is left as an exercise to the reader.

Signed-off-by: Adam Reif Garandor@manta.network

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Adam Reif added 4 commits April 7, 2023 13:11
…-local

Signed-off-by: Adam Reif <Garandor@manta.network>
… the file in the ansible repo)

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime C-cleanup Category: Issues documenting cleanup or PRs that clean code up A-development Area: Development Resources and Upgrades L-added Log: Issues and PRs related to addition labels Apr 7, 2023
@Garandor Garandor self-assigned this Apr 7, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, looks good

node/src/chain_specs/manta/mod.rs Show resolved Hide resolved
Adam Reif added 2 commits April 11, 2023 12:50
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@ghzlatarev ghzlatarev merged commit 7c389f9 into manta Apr 13, 2023
@ghzlatarev ghzlatarev deleted the garandor/manta-genesis-refactor branch April 13, 2023 06:46
@ghzlatarev ghzlatarev linked an issue Apr 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-development Area: Development Resources and Upgrades A-manta Area: Issues and PRs related to the Manta Runtime C-cleanup Category: Issues documenting cleanup or PRs that clean code up C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new manta-local chainspec for manta benchmarking
3 participants