Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip integration tests #1068

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Do not skip integration tests #1068

merged 2 commits into from
Apr 10, 2023

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Apr 10, 2023

Description

Some how we skipped integration tests after pr #1050.


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping added A-calamari Area: Issues and PRs related to the Calamari Runtime A-automation Area: Issues and PRs related to Automation A-ci Area: Continuous Integration T-runtime Team: Relevant for the Runtime Team C-cleanup Category: Issues documenting cleanup or PRs that clean code up A-testing Area: Testing-related Issues and PRs L-fixed Log: Issues and PRs related to bug fixes labels Apr 10, 2023
@Dengjianping Dengjianping self-assigned this Apr 10, 2023
Signed-off-by: Dengjianping <djptux@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 10, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

@Dengjianping Dengjianping merged commit ba61b45 into manta Apr 10, 2023
@Dengjianping Dengjianping deleted the fix-integration-tests branch April 10, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-automation Area: Issues and PRs related to Automation A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-testing Area: Testing-related Issues and PRs C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-fixed Log: Issues and PRs related to bug fixes T-runtime Team: Relevant for the Runtime Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants