Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge 0-asset XCM instructions as if they were 1-asset #1071

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Apr 12, 2023

Punish valid-but-pointless XCM instructions by charging a fee on our chain ( used to be 0 weight )

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-xcm Area: Issues and PRs related to Cross-Consensus Messaging (XCM) A-dolphin Area: Issues and PRs related to the Dolphin Runtime L-changed Log: Issues and PRs related to changes labels Apr 12, 2023
@Garandor Garandor self-assigned this Apr 12, 2023
@github-actions
Copy link

github-actions bot commented Apr 12, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

ferrell-code
ferrell-code approved these changes Apr 12, 2023
@ghzlatarev ghzlatarev merged commit 0732a13 into manta Apr 13, 2023
@ghzlatarev ghzlatarev deleted the garandor/charge_xcm_spam branch April 13, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-xcm Area: Issues and PRs related to Cross-Consensus Messaging (XCM) C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants