Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.4.0 #1229

Merged
merged 13 commits into from
Jul 22, 2023
Merged

Release v4.4.0 #1229

merged 13 commits into from
Jul 22, 2023

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Jul 20, 2023

Description

relates #1225

  • additionally unfilter xTokens.transfer_mutliasset_with_fee for MRL program

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code ferrell-code added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes L-skip Log: Will be skipped on changelog generation labels Jul 20, 2023
@github-actions
Copy link

github-actions bot commented Jul 20, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 20, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

Signed-off-by: Charles Ferrell <charlie@manta.network>
@ghzlatarev ghzlatarev linked an issue Jul 21, 2023 that may be closed by this pull request
42 tasks
ghzlatarev and others added 7 commits July 21, 2023 11:40
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ghzlatarev and others added 3 commits July 22, 2023 18:04
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
Copy link
Contributor Author

what about calamari weights ? https://github.com/Manta-Network/Manta/actions/runs/5631291209 https://github.com/Manta-Network/Manta/actions/runs/5631312134

ya I ran it last night when I realized I needed calamari, should be good now

@ghzlatarev ghzlatarev merged commit c869bc9 into manta Jul 22, 2023
@ghzlatarev ghzlatarev deleted the release-4.4.0 branch July 22, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes C-enhancement Category: An issue proposing an enhancement or a PR with one L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manta/Calamari v4400 Release checklist
3 participants