Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manta] Add dockerfile #14

Merged
merged 3 commits into from
May 3, 2021
Merged

[Manta] Add dockerfile #14

merged 3 commits into from
May 3, 2021

Conversation

Dengjianping
Copy link
Contributor

Add dockerfile for our project.

  • Build(example)
cd Manta
docker build -t mantanetwork/manta:manta-nightly .
  • Run(example)
docker run -it -p 9944:9944 mantanetwork/manta:manta-nightly --dev --unsafe-ws-external

@Dengjianping Dengjianping mentioned this pull request Apr 30, 2021
Closed
39 tasks
zhenfeizhang
zhenfeizhang approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@zhenfeizhang zhenfeizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. builds on my computer

@Dengjianping Dengjianping changed the title Add dockerfile [Manta] Add dockerfile May 1, 2021
stechu
stechu requested changes May 2, 2021
View reviewed changes
Copy link
Collaborator

@stechu stechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add docker running instructions to readme.md?

@Dengjianping
Copy link
Contributor Author

Sure, I'll do it later.

@Dengjianping
Copy link
Contributor Author

@stechu I just added a section about how to use docker run our node.

@stechu
Copy link
Collaborator

stechu commented May 3, 2021

LGTM. merged.

@stechu stechu merged commit 49a90ec into manta May 3, 2021
@stechu stechu deleted the dockerize branch May 3, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stechu stechu stechu requested changes

@zhenfeizhang zhenfeizhang zhenfeizhang approved these changes

@grenade grenade Awaiting requested review from grenade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dengjianping @stechu @zhenfeizhang