Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client trait bound refactor #836

Merged
merged 5 commits into from
Oct 14, 2022
Merged

client trait bound refactor #836

merged 5 commits into from
Oct 14, 2022

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented Oct 12, 2022

Signed-off-by: zqhxuyuan zqhxuyuan@gmail.com

Description

relates to OR closes: #837


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@zqhxuyuan zqhxuyuan added the A-client Client - i.e. not upgradeable with the runtime - changes label Oct 12, 2022
@zqhxuyuan zqhxuyuan self-assigned this Oct 12, 2022
@zqhxuyuan zqhxuyuan added C-good-first-issue Category: Good first issues L-fixed Log: Issues and PRs related to bug fixes labels Oct 12, 2022
@zqhxuyuan zqhxuyuan added this to the 3.4.2 milestone Oct 12, 2022
Dengjianping
Dengjianping previously approved these changes Oct 12, 2022
Copy link
Contributor

@Dengjianping Dengjianping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pr, but not sure it should be included with v3.4.2.
@Garandor

node/src/client.rs Outdated Show resolved Hide resolved
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@Garandor
Copy link
Contributor

for this PR L-changed is more appropriate. fixed is really only for bugs

node/src/client.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM! :)

@zqhxuyuan zqhxuyuan added L-changed Log: Issues and PRs related to changes and removed L-fixed Log: Issues and PRs related to bug fixes labels Oct 14, 2022
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@ghzlatarev
Copy link
Contributor

Looks good.
Please update the branch and finish the checklist.

@zqhxuyuan zqhxuyuan added the A-calamari Area: Issues and PRs related to the Calamari Runtime label Oct 14, 2022
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghzlatarev ghzlatarev merged commit f264dbd into manta Oct 14, 2022
@ghzlatarev ghzlatarev deleted the client_trait_refactor branch October 14, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-client Client - i.e. not upgradeable with the runtime - changes C-good-first-issue Category: Good first issues L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node service trait bound refactor
4 participants