Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.0.0 alpha1 #910

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Release v4.0.0 alpha1 #910

merged 3 commits into from
Dec 9, 2022

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Dec 7, 2022

Description

Internal pre-release

Left for later:

  • Recompute weights
  • Changelog

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

@Garandor Garandor added L-release Related to a release A-calamari Area: Issues and PRs related to the Calamari Runtime C-experiment Category: Experimental feature or tool labels Dec 7, 2022
@Garandor Garandor mentioned this pull request Dec 8, 2022
6 tasks
Adam Reif added 2 commits December 8, 2022 21:11
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@ghzlatarev ghzlatarev added the A-dolphin Area: Issues and PRs related to the Dolphin Runtime label Dec 9, 2022
@ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev added this to the v4.0.0 milestone Dec 9, 2022
@ghzlatarev ghzlatarev added A-manta-pay Area: Issues and PRs related to the MantaPay Pallet L-changed Log: Issues and PRs related to changes labels Dec 9, 2022
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev marked this pull request as ready for review December 9, 2022 15:45
@ghzlatarev ghzlatarev linked an issue Dec 9, 2022 that may be closed by this pull request
29 tasks
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nimubs dependencies are still 3.4.3 if we want to mirror this repo

It probably is fine to leave as is, because there are no nimbus changes.

@stechu stechu merged commit 77b79e6 into manta Dec 9, 2022
@stechu stechu deleted the release-v4.0.0-alpha1 branch December 9, 2022 18:05
@Garandor Garandor added L-skip Log: Will be skipped on changelog generation and removed L-changed Log: Issues and PRs related to changes L-release Related to a release labels Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet C-experiment Category: Experimental feature or tool L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manta v4.0.0-alpha1 Release checklist
4 participants