Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nimbus #944

Merged
merged 4 commits into from
Dec 23, 2022
Merged

Update nimbus #944

merged 4 commits into from
Dec 23, 2022

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Dec 22, 2022

Description

This change removes AuthorFilterAPI runtime API as a result of
moonbeam-foundation/nimbus@17ba75f

Our client was already not using this API so there should be no impact.

There are no further functional changes to the previous v3.4.3 tag (run git diff v3.4.3..v4.0.0 to verify)

It also changes us to a simplified branch structure on nimbus.

  • upstreamable: branched off from main. Contains changes we can eventually upstream
  • manta: branched off from upstreamable. Manta-specific changes that we likely won't upstream

the v4.0.0 tag this PR uses and all future tags always point to the manta branch, which will get changes from main merged in periodically.


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

@Garandor Garandor added A-calamari Area: Issues and PRs related to the Calamari Runtime P-high Priority: High A-dolphin Area: Issues and PRs related to the Dolphin Runtime C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes A-client Client - i.e. not upgradeable with the runtime - changes and removed P-high Priority: High labels Dec 22, 2022
Adam Reif added 2 commits December 22, 2022 14:42
Signed-off-by: Adam Reif <Garandor@manta.network>
fmt
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor force-pushed the garandor/nimbus_branch_change branch from fb46150 to 884f20f Compare December 22, 2022 20:42
@Garandor Garandor changed the title BREAKING: Update nimbus Update nimbus Dec 22, 2022
@Garandor Garandor linked an issue Dec 22, 2022 that may be closed by this pull request
@Garandor Garandor self-assigned this Dec 22, 2022
Adam Reif added 2 commits December 22, 2022 15:25
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor merged commit b02e73d into manta Dec 23, 2022
@Garandor Garandor deleted the garandor/nimbus_branch_change branch December 23, 2022 21:39
ferrell-code pushed a commit that referenced this pull request Dec 27, 2022
* CLIENT BREAKING: Upgrade nimbus to v4.0.0, removes AuthorFilterAPI

Signed-off-by: Adam Reif <Garandor@manta.network>

* fmt

Signed-off-by: Adam Reif <Garandor@manta.network>

* fix build

Signed-off-by: Adam Reif <Garandor@manta.network>

* clippy fix

Signed-off-by: Adam Reif <Garandor@manta.network>

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-client Client - i.e. not upgradeable with the runtime - changes A-dolphin Area: Issues and PRs related to the Dolphin Runtime C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nimbus Branch Structure
3 participants