Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: distinguish between panic-errors and possible-fix-errors #949

Merged
merged 2 commits into from
Dec 28, 2022
Merged

fix: distinguish between panic-errors and possible-fix-errors #949

merged 2 commits into from
Dec 28, 2022

Conversation

ferrell-code
Copy link
Contributor

Signed-off-by: Charles Ferrell charlie@manta.network

closes: #464

@ferrell-code
fix error handling
2d042b1 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code ferrell-code added A-calamari Area: Issues and PRs related to the Calamari Runtime C-cleanup Category: Issues documenting cleanup or PRs that clean code up A-manta-pay Area: Issues and PRs related to the MantaPay Pallet L-changed Log: Issues and PRs related to changes labels Dec 27, 2022
@ferrell-code ferrell-code mentioned this pull request Dec 28, 2022
Closed
6 tasks
@ferrell-code
use rev instead of patch
44332fa 
Signed-off-by: Charles Ferrell <charlie@manta.network>
Garandor
Garandor reviewed Dec 28, 2022
View reviewed changes
Copy link
Contributor

@Garandor Garandor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine so far

Garandor
Garandor approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so if I get this correctly, the extrinsic will simply fail if we encounter an InternalLedgerError.

We need a followup topic to this:
Trigger tx-pause freeze of chain state on InternalLedgerError

@Garandor Garandor mentioned this pull request Dec 28, 2022
Closed
@ghzlatarev ghzlatarev merged commit 3d1ea94 into manta Dec 28, 2022
@ghzlatarev ghzlatarev deleted the fer/distinguish-errors branch December 28, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@Garandor Garandor Garandor approved these changes

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

@Dengjianping Dengjianping Awaiting requested review from Dengjianping

Assignees
No one assigned
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove panicking errors in manta-pay code
3 participants
@ferrell-code @Garandor @ghzlatarev