Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all imported constants to our code base #976

Merged
merged 15 commits into from
Jan 16, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Jan 9, 2023

Description

Move constants to our code-base, in order to not have them change without us realizing:

  • BlockExecutionWeight
  • ExtrinsicBaseWeight
  • WEIGHT_PER_SECOND
  • BlockHashCount
  • RocksDbWeight
  • SlowAdjustingFeeUpdate

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

ghzlatarev and others added 9 commits January 6, 2023 14:23
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added L-changed Log: Issues and PRs related to changes A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes A-dolphin Area: Issues and PRs related to the Dolphin Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one labels Jan 9, 2023
@ghzlatarev ghzlatarev changed the title Ghzlatarev/control constants Move all imported constants to our code base Jan 9, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev marked this pull request as ready for review January 9, 2023 11:08
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ferrell-code
ferrell-code previously approved these changes Jan 11, 2023
@Dengjianping
Copy link
Contributor

what about this RocksDbWeight in weight files? Maybe you have to update weight template.
https://github.com/Manta-Network/Manta/blob/manta/runtime/calamari/src/weights/calamari_vesting.rs#L43

@ghzlatarev
Copy link
Contributor Author

They will be regenerated in the release PR, but I can also do it here if you guys want.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@Dengjianping
Copy link
Contributor

They will be regenerated in the release PR, but I can also do it here if you guys want.

Yeah, we can fix it in next release.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev and others added 2 commits January 13, 2023 23:24
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev self-assigned this Jan 14, 2023
@ghzlatarev ghzlatarev merged commit b0095a5 into manta Jan 16, 2023
@ghzlatarev ghzlatarev deleted the ghzlatarev/control-constants branch January 16, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-runtime Area: Issues and PRs related to Runtimes C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All constants should be controlled by us completely except special reason.
4 participants