Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.0.1 #994

Merged
merged 7 commits into from
Jan 19, 2023
Merged

Release v4.0.1 #994

merged 7 commits into from
Jan 19, 2023

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Jan 18, 2023

Signed-off-by: Adam Reif Garandor@manta.network

Description

partly adddresses #965

  • MantaPay used to not follow crate version convention. Now it does.
  • use manta_primitives::RocksDbWeight -> use manta_primitives::constants::RocksDbWeight
  • Manta Runtime Benchmarks failing tracked in Resolve manta RT benchmarking issue #995

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Adam Reif added 7 commits January 17, 2023 17:58
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
…g leave request

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes A-dolphin Area: Issues and PRs related to the Dolphin Runtime L-skip Log: Will be skipped on changelog generation labels Jan 18, 2023
@Garandor Garandor self-assigned this Jan 18, 2023
@Garandor Garandor added the A-manta Area: Issues and PRs related to the Manta Runtime label Jan 18, 2023
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment above, not sure if it is already a known thing.

@Garandor
Copy link
Contributor Author

Leaving this open for tonight, @ghzlatarev merge when you think acceptable

@Garandor Garandor merged commit 5b72639 into manta Jan 19, 2023
@Garandor Garandor deleted the release-v4.0.1 branch January 19, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes C-enhancement Category: An issue proposing an enhancement or a PR with one L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants