Add a dynamic scale bar and announce a scale ratio for each map view for screen readers #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kevinkim31 merged 59 commits into Maps4HTML:main from kevinkim31:map-scalebar

Apr 6, 2023

Contributor

kevinkim31 commented Mar 13, 2023

closes #777


          create scalebar control module

3c1d6fc

Member

prushforth commented Mar 13, 2023 •

edited

Loading

Haven't listened to it yet, but looks nice. I think you'll have to adjust the space between the scalebar and the bottom of the map, up a bit, because on maps that display links, the links draw over top of the scalebar. Note that the scale ratios look incorrect when zooming on the linked map.

kevinkim31 added 3 commits

March 13, 2023 16:35


          move scalebar up to give space for link

ac6a7a1


          update for controlslist functionality

cd30bd7


          initial announce template

989a70b

Contributor Author

kevinkim31 commented Mar 15, 2023

initial announce template

Not ready for review just yet. Still need to work on the announcing but should be done soon.

kevinkim31 added 2 commits

March 15, 2023 16:29


          some changes ; needs fixing up

50382d1


          changes for announce

7cebec6

AliyanH reviewed

View reviewed changes

src/mapml-viewer.js Outdated Show resolved Hide resolved

kevinkim31 added 10 commits

March 20, 2023 13:30


          slight modifications

7d5cff7


          parsefloat to prevent .0 from being read out

13a7aaa


          read on load

e147cc0


          web-map

50dfd54


          fix and add testing

bdbff0a


          move scalebar down a bit

e6b4b90


          problem with tabbing back in

bff95bd


          add tab indexing

7981f64


          fix testing

734c27a


          clean up code

e7cb79a

prushforth reviewed

View reviewed changes

src/mapml/control/AnnounceScale.js Outdated Show resolved Hide resolved

prushforth reviewed

View reviewed changes

src/mapml-viewer.js Outdated Show resolved Hide resolved

prushforth reviewed

View reviewed changes

src/mapml/control/AnnounceScale.js Outdated Show resolved Hide resolved

prushforth reviewed

View reviewed changes

src/mapml/control/AnnounceScale.js Outdated Show resolved Hide resolved

prushforth reviewed

View reviewed changes

src/mapml/control/ScaleBar.js Outdated Show resolved Hide resolved

prushforth reviewed

View reviewed changes

src/mapml/control/ScaleBar.js Outdated Show resolved Hide resolved

prushforth reviewed

View reviewed changes

src/mapml/control/ScaleBar.js Outdated Show resolved Hide resolved

prushforth reviewed

View reviewed changes

src/mapml/control/ScaleBar.js Outdated Show resolved Hide resolved

prushforth reviewed

View reviewed changes

src/mapml/control/ScaleBar.js Outdated Show resolved Hide resolved

prushforth reviewed

View reviewed changes

src/mapml/control/ScaleBar.js Outdated Show resolved Hide resolved

prushforth reviewed

View reviewed changes

src/web-map.js Outdated Show resolved Hide resolved

kevinkim31 and others added 29 commits

April 6, 2023 12:22


          some changes ; needs fixing up

21de21f


          changes for announce

cc868bc


          slight modifications

1caa716


          parsefloat to prevent .0 from being read out

73a2d97


          read on load

bd64364


          web-map

c54aab7


          fix and add testing

5f8e377


          move scalebar down a bit


          problem with tabbing back in

8579fef


          add tab indexing

9572b0a


          fix testing

d5f00e1


          clean up code

269104b


          implement changes

00e379a


          Rename AnnounceMovement handler to PanZoom / meaningfulPanZoom handler

864fbca


          Revert "Rename AnnounceMovement handler to PanZoom / meaningfulPanZoo…

b6561e6

…m handler"

This reverts commit c557804.


          integrate both scales to one

509bf84


          Remove _container member property.

7c642df


          Make scalebar control creation conditional, similar to other controls

8c0344c


          fix styling


          fix styling

66ec9cf


          fix styling

3df5442


          fix styling

762bc5e


          set scalebar position based on initial map size

357e623


          Fix some stuff broken during conflict resolution

99b02cd


          Merge branch 'map-scalebar' of https://github.com/kevinkim31/Web-Map-…

b4fd653

…Custom-Element into map-scalebar


          Account for scalebar control in location control tests (need extra tab)

5bc3032

Fix lint errors


          final changes

1aab4bb


          final changes

41f2334


          final changes

247aec2

kevinkim31 merged commit 2b0342b into Maps4HTML:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet