Skip to content

remove setter for map-extent units attribute #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023
Merged

remove setter for map-extent units attribute #908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/map-extent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
/* global M */
export class MapExtent extends HTMLElement {
static get observedAttributes() {
return ['units', 'checked', 'label', 'opacity', 'hidden'];
return ['checked', 'label', 'opacity', 'hidden'];
}
get units() {
return this.getAttribute('units');
}
set units(val) {
// built in support for OSMTILE, CBMTILE, WGS84 and APSTILE
if (['OSMTILE', 'CBMTILE', 'WGS84', 'APSTILE'].includes(val)) {
this.setAttribute('units', val);
}
// else need to check with the mapml-viewer element if the custom projection is defined
}

get checked() {
return this.hasAttribute('checked');
}
Expand Down