align max players of automod to documentation #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation mentions max players in seeding automod to be exclusive, but the code handled it inclusive. This commit aligns the code to the documentation again.
cemathey
approved these changes
May 17, 2024
ElGuillermo
approved these changes
May 17, 2024
timraay
added a commit
that referenced
this pull request
May 31, 2024
commit 3b66c4e Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 29 15:40:11 2024 -0600 Return a dict for get_slots commit d436388 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 29 14:02:45 2024 -0600 Add comments, typing commit bd9c59e Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 29 13:46:00 2024 -0600 Rework Faction for easier consumption of API data commit e431408 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 29 12:15:51 2024 -0600 Rename and correct typing commit 9c13d42 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 14:43:32 2024 -0600 Fix typo commit ab2e1a0 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 13:41:20 2024 -0600 Don't include `self` in API documentation commit c0500b7 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 13:41:09 2024 -0600 Remove unused file commit 6839794 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 12:48:28 2024 -0600 Rename do_reconnect_gameserver to reconnect_gameserver commit dfe1f95 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 12:31:58 2024 -0600 Install dependencies in one go commit baab261 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 12:12:16 2024 -0600 Update compose file for running the backend/frontend dev servers commit f971d86 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 12:11:43 2024 -0600 Reduce disk utilization commit a5e6cac Merge: 2f5d6da edac694 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 11:49:56 2024 -0600 Merge branch 'master' into feat/autosettings_all_rcon_methods commit edac694 Author: ElGuillermo <66552553+ElGuillermo@users.noreply.github.com> Date: Tue May 28 19:34:43 2024 +0200 Update README.md (#566) commit 9680848 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 28 11:34:09 2024 -0600 Bump sqlalchemy from 2.0.29 to 2.0.30 (#570) Bumps [sqlalchemy](https://github.com/sqlalchemy/sqlalchemy) from 2.0.29 to 2.0.30. - [Release notes](https://github.com/sqlalchemy/sqlalchemy/releases) - [Changelog](https://github.com/sqlalchemy/sqlalchemy/blob/main/CHANGES.rst) - [Commits](https://github.com/sqlalchemy/sqlalchemy/commits) --- updated-dependencies: - dependency-name: sqlalchemy dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 3f59440 Author: ExcuseMi <ExcuseMi@users.noreply.github.com> Date: Tue May 28 19:33:11 2024 +0200 Fix error in log stream when server is idle (#565) Fixes TypeError: cannot unpack non-iterable NoneType object when server has be idle in the log stream. The scenario occurs when last_seen is None and the tail returns None commit 21abeb6 Author: Florian <florian.schmidt.welzow@t-online.de> Date: Tue May 28 19:32:26 2024 +0200 Salvage stats when player reconnects (#568) Previously, when a player disconnects and then reconnects to the server the stats gained in the previous session where lost. The CRCON would always only save the 'higher' stats value to compensate this a bit, which was far from perfect. With this commit, the CRCON will try to salvage the previously gained stats and combine them after the round ended. commit 33efff1 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 28 11:30:37 2024 -0600 Bump rq from 1.16.1 to 1.16.2 (#569) Bumps [rq](https://github.com/rq/rq) from 1.16.1 to 1.16.2. - [Release notes](https://github.com/rq/rq/releases) - [Changelog](https://github.com/rq/rq/blob/master/CHANGES.md) - [Commits](rq/rq@v1.16.1...v1.16.2) --- updated-dependencies: - dependency-name: rq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 094c479 Author: C. Eric Mathey <48801688+cemathey@users.noreply.github.com> Date: Tue May 28 11:29:08 2024 -0600 Include player ID when kicking, can't retrieve it from the game server post kick (#573) commit 3c7f255 Author: Florian <florian.schmidt.welzow@t-online.de> Date: Tue May 28 19:28:26 2024 +0200 align max players of automod to documentation (#575) The documentation mentions max players in seeding automod to be exclusive, but the code handled it inclusive. This commit aligns the code to the documentation again. commit 5373159 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 28 11:28:00 2024 -0600 Bump pytest from 8.1.1 to 8.2.1 (#577) Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.1.1 to 8.2.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@8.1.1...8.2.1) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 468607e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 28 11:27:23 2024 -0600 Bump requests from 2.31.0 to 2.32.2 (#579) Bumps [requests](https://github.com/psf/requests) from 2.31.0 to 2.32.2. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.31.0...v2.32.2) --- updated-dependencies: - dependency-name: requests dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2f5d6da Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 10:25:46 2024 -0600 Support errors_as_json for InvalidKeysConfigurationError commit 93ae6e6 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 10:15:14 2024 -0600 Remove upload_vips and rename async_upload_vips commit 40eb693 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 09:53:02 2024 -0600 Fix arguments for unwatch_player commit cf0c5ad Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 09:38:57 2024 -0600 Return unban_profanities and result as a bool and not str commit edd4090 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 28 09:24:48 2024 -0600 Return temp_ban and result as a bool and not str and add type hints commit 847decc Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 15:32:49 2024 -0600 Return switch_player_now and switch_player_on_death result as a bool and not str commit d1103b5 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 14:59:23 2024 -0600 Refactor set_welcome_message commit 6815ee6 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 14:36:12 2024 -0600 Accept set_votekick_thresholds threshold_pairs as a list of tuples commit 6af7899 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 14:35:08 2024 -0600 Return set_votekick_enabled result as a bool and not str commit 4f8185a Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 14:06:14 2024 -0600 Return set_vip_slots_num result as a bool and not str and change parameter name commit 0621d6f Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 13:59:34 2024 -0600 Return set_team_switch_cooldown result as a bool and not str commit 08f76c1 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 13:19:40 2024 -0600 Accept either lists of strings or dicts for StandardBroadcastMessages commit 9de1b87 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 11:37:21 2024 -0600 Return set_queue_length result as a bool and not str and change parameter name commit 1c32221 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 11:27:55 2024 -0600 Remove set_name it was already moved to RconAPI as set_server_name commit 8f42a99 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 11:15:12 2024 -0600 Return set_max_ping_autokick result as a bool and not str commit 0a6d9b0 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 11:11:10 2024 -0600 Rename set_map_votemap_whitelist to set_votemap_whitelist and standardize parameter name commit ae4c268 Author: C. Eric Mathey <emathey@protonmail.com> Date: Wed May 22 10:20:28 2024 -0600 Move user config error conversion (str or JSON) to the API exposure level commit 9ab90ac Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 16:31:13 2024 -0600 Return set_idle_autokick_time result as a bool and not str commit 71eb083 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 16:00:24 2024 -0600 Refactor set_broadcast commit 82adedc Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 15:04:19 2024 -0600 Return set_autobalance_threshold result as a bool and not str commit d88d903 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 14:54:13 2024 -0600 Rename bool_ parameter to value commit ef19f73 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 14:26:54 2024 -0600 Return set_autobalance_enabled result as a bool and not str commit c2ab2c5 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 13:31:33 2024 -0600 Bandaid AutoBroadcastUserConfig (accept both UI format as one string and the JSON format) commit 2728724 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 13:13:49 2024 -0600 Rename server_list endpoint get_server_list commit f099fe2 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 12:20:08 2024 -0600 Return reset_votekick_thresholds result as a bool and not str commit 074a824 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 12:06:47 2024 -0600 Return remove_vip result as a bool and not str commit 897b0a8 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 11:57:47 2024 -0600 Return results as boolean, accept player ID for perma ban and fix remove temp/perma ban due to receiving parsed banlogs not raw banlogs commit e8d457f Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 10:21:43 2024 -0600 Return remove_all_vips result as a bool and not str commit 2086c60 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 10:19:58 2024 -0600 Return command result for remove_map_from_rotation commit 772f077 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 09:54:43 2024 -0600 Fix player count in browser page title commit b3b707c Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 09:48:29 2024 -0600 Fix player slots (current, max) usage commit d1efa04 Author: C. Eric Mathey <emathey@protonmail.com> Date: Tue May 21 09:47:46 2024 -0600 Return punish result as a bool and not str commit aa75c92 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Apr 29 10:19:17 2024 -0600 Bump black from 24.4.0 to 24.4.2 (#562) Bumps [black](https://github.com/psf/black) from 24.4.0 to 24.4.2. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@24.4.0...24.4.2) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 36f9ac2 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Apr 29 10:14:14 2024 -0600 Bump pydantic from 2.7.0 to 2.7.1 (#563) Bumps [pydantic](https://github.com/pydantic/pydantic) from 2.7.0 to 2.7.1. - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v2.7.0...v2.7.1) --- updated-dependencies: - dependency-name: pydantic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 4d37232 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Apr 29 10:11:16 2024 -0600 Bump redis from 5.0.3 to 5.0.4 (#564) Bumps [redis](https://github.com/redis/redis-py) from 5.0.3 to 5.0.4. - [Release notes](https://github.com/redis/redis-py/releases) - [Changelog](https://github.com/redis/redis-py/blob/master/CHANGES) - [Commits](redis/redis-py@v5.0.3...v5.0.4) --- updated-dependencies: - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2af20bf Author: C. Eric Mathey <48801688+cemathey@users.noreply.github.com> Date: Fri Apr 26 11:59:07 2024 -0600 Update map picture lookup (#560) commit b21fbb8 Author: ElGuillermo <66552553+ElGuillermo@users.noreply.github.com> Date: Fri Apr 26 19:58:55 2024 +0200 Update seeding_rules.py (#559) adding new skirmish maps Signed-off-by: ElGuillermo <66552553+ElGuillermo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation mentions max players in seeding automod to be exclusive, but the code handled it inclusive. This commit aligns the code to the documentation again.