Skip to content

Commit 05c33d6

Browse files
dr-msanja-byelkin
authored andcommitted
MDEV-27736 Allow seamless upgrade despite ROW_FORMAT=COMPRESSED
In commit 9bc874a (MDEV-23497) the configuration option innodb_read_only_compressed was introduced to giver users advance notice of a plan to remove ROW_FORMAT=COMPRESSED support for InnoDB. Based on user feedback, this plan has been scrapped. Even though ROW_FORMAT=COMPRESSED is a dead end and causes some overhead for InnoDB data structures, we can live with that. Now that we know that some users really want to keep using ROW_FORMAT=COMPRESSED, the previous default value of the parameter innodb_read_only_compressed=ON should be changed to OFF, to allow smooth upgrades to 10.6 and later versions, without requiring users to update any configuration file.
1 parent f5c5f8e commit 05c33d6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

mysql-test/suite/sys_vars/r/sysvars_innodb.result

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1427,10 +1427,10 @@ READ_ONLY YES
14271427
COMMAND_LINE_ARGUMENT OPTIONAL
14281428
VARIABLE_NAME INNODB_READ_ONLY_COMPRESSED
14291429
SESSION_VALUE NULL
1430-
DEFAULT_VALUE ON
1430+
DEFAULT_VALUE OFF
14311431
VARIABLE_SCOPE GLOBAL
14321432
VARIABLE_TYPE BOOLEAN
1433-
VARIABLE_COMMENT Make ROW_FORMAT=COMPRESSED tables read-only (ON by default)
1433+
VARIABLE_COMMENT Make ROW_FORMAT=COMPRESSED tables read-only
14341434
NUMERIC_MIN_VALUE NULL
14351435
NUMERIC_MAX_VALUE NULL
14361436
NUMERIC_BLOCK_SIZE NULL

storage/innobase/handler/ha_innodb.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19615,8 +19615,8 @@ static MYSQL_SYSVAR_BOOL(read_only, srv_read_only_mode,
1961519615

1961619616
static MYSQL_SYSVAR_BOOL(read_only_compressed, innodb_read_only_compressed,
1961719617
PLUGIN_VAR_OPCMDARG,
19618-
"Make ROW_FORMAT=COMPRESSED tables read-only (ON by default)",
19619-
NULL, NULL, TRUE);
19618+
"Make ROW_FORMAT=COMPRESSED tables read-only",
19619+
NULL, NULL, FALSE);
1962019620

1962119621
static MYSQL_SYSVAR_BOOL(cmp_per_index_enabled, srv_cmp_per_index_enabled,
1962219622
PLUGIN_VAR_OPCMDARG,

0 commit comments

Comments
 (0)