Skip to content

Commit 067b90c

Browse files
committed
Fix MinSizeRel build on Windows.
do not include test suite in release zip anymore.
1 parent 477a1bc commit 067b90c

File tree

3 files changed

+26
-13
lines changed

3 files changed

+26
-13
lines changed

cmake/build_configurations/mysql_release.cmake

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ IF(FEATURE_SET)
6262
SET(WITH_NONE ON)
6363
ENDIF()
6464

65-
IF(num GREATER FEATURE_SET_xsmall)
65+
IF(num GREATER FEATURE_SET_xsmall AND NOT WIN32)
6666
SET(WITH_EMBEDDED_SERVER ON CACHE BOOL "")
6767
ENDIF()
6868
IF(num GREATER FEATURE_SET_small)
@@ -88,7 +88,9 @@ ENDIF()
8888
OPTION(ENABLED_LOCAL_INFILE "" ON)
8989
SET(WITH_INNODB_SNAPPY OFF CACHE STRING "")
9090
IF(WIN32)
91-
SET(WITH_LIBARCHIVE STATIC CACHE STRING "")
91+
SET(INSTALL_MYSQLTESTDIR "" CACHE STRING "")
92+
SET(INSTALL_SQLBENCHDIR "" CACHE STRING "")
93+
SET(INSTALL_SUPPORTFILESDIR "" CACHE STRING "")
9294
ELSEIF(RPM)
9395
SET(WITH_SSL system CACHE STRING "")
9496
SET(WITH_ZLIB system CACHE STRING "")

cmake/os/Windows.cmake

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,10 @@ IF(MSVC)
8686
# Enable debug info also in Release build,
8787
# and create PDB to be able to analyze crashes.
8888
FOREACH(type EXE SHARED MODULE)
89-
SET(CMAKE_{type}_LINKER_FLAGS_RELEASE
89+
SET(CMAKE_${type}_LINKER_FLAGS_RELEASE
9090
"${CMAKE_${type}_LINKER_FLAGS_RELEASE} /debug")
91+
SET(CMAKE_${type}_LINKER_FLAGS_MINSIZEREL
92+
"${CMAKE_${type}_LINKER_FLAGS_MINSIZEREL} /debug")
9193
ENDFOREACH()
9294

9395
# Force static runtime libraries
@@ -108,10 +110,15 @@ IF(MSVC)
108110
CMAKE_C_FLAGS_RELEASE CMAKE_C_FLAGS_RELWITHDEBINFO
109111
CMAKE_C_FLAGS_DEBUG CMAKE_C_FLAGS_DEBUG_INIT
110112
CMAKE_CXX_FLAGS_RELEASE CMAKE_CXX_FLAGS_RELWITHDEBINFO
111-
CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_DEBUG_INIT)
113+
CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_DEBUG_INIT
114+
CMAKE_C_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_MINSIZEREL
115+
)
112116
STRING(REGEX REPLACE "/M[TD][d]?" "${MSVC_CRT_TYPE}" "${flag}" "${${flag}}" )
113117
STRING(REGEX REPLACE "/D[ ]?_DEBUG" "" "${flag}" "${${flag}}")
114118
STRING(REPLACE "/Zi" "/Z7" "${flag}" "${${flag}}")
119+
IF(NOT "${${flag}}" MATCHES "/Z7")
120+
STRING(APPEND ${flag} " /Z7")
121+
ENDIF()
115122
ENDFOREACH()
116123

117124

mysql-test/lib/My/SafeProcess/CMakeLists.txt

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,16 @@
1313
# along with this program; if not, write to the Free Software
1414
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
1515

16-
IF (NOT INSTALL_MYSQLTESTDIR)
16+
17+
IF (WIN32)
18+
ADD_EXECUTABLE(my_safe_process safe_process_win.cc)
19+
ADD_EXECUTABLE(my_safe_kill safe_kill_win.cc)
20+
TARGET_LINK_LIBRARIES(my_safe_kill dbghelp psapi)
21+
ELSE()
22+
ADD_EXECUTABLE(my_safe_process safe_process.cc)
23+
ENDIF()
24+
25+
IF(NOT INSTALL_MYSQLTESTDIR)
1726
RETURN()
1827
ENDIF()
1928

@@ -22,14 +31,9 @@ SET(INSTALL_ARGS
2231
COMPONENT Test
2332
)
2433

34+
INSTALL(TARGETS my_safe_process ${INSTALL_ARGS})
2535
IF (WIN32)
26-
MYSQL_ADD_EXECUTABLE(my_safe_process safe_process_win.cc ${INSTALL_ARGS})
27-
MYSQL_ADD_EXECUTABLE(my_safe_kill safe_kill_win.cc ${INSTALL_ARGS})
28-
TARGET_LINK_LIBRARIES(my_safe_kill dbghelp psapi)
29-
ELSE()
30-
MYSQL_ADD_EXECUTABLE(my_safe_process safe_process.cc ${INSTALL_ARGS})
36+
INSTALL(TARGETS my_safe_kill ${INSTALL_ARGS})
3137
ENDIF()
3238

33-
INSTALL(FILES Base.pm
34-
DESTINATION "${INSTALL_MYSQLTESTDIR}/lib/My/SafeProcess" COMPONENT Test
35-
)
39+
INSTALL(FILES Base.pm ${INSTALL_ARGS})

0 commit comments

Comments
 (0)