MDEV-30651: Assertion `sel->quick' in make_range_rowid_filters, followup

spetrunia · spetrunia · commit 0903276eaea3 · 2024-06-17T14:08:32.000+03:00
Review followup: RANGE_OPT_PARAM statement_should_be_aborted()
checks for thd-&gt;is_fatal_error and thd-&gt;is_error(). The first is
redundant when the second is present.
diff --git a/sql/opt_range.h b/sql/opt_range.h
@@ -736,7 +736,6 @@ class RANGE_OPT_PARAM
   {
     return
       thd->killed ||
-      thd->is_fatal_error ||
       thd->is_error() ||
       alloced_sel_args > SEL_ARG::MAX_SEL_ARGS;
   }

Original file line number	Diff line number	Diff line change
`@@ -736,7 +736,6 @@ class RANGE_OPT_PARAM`
`736`	`736`	`{`
`737`	`737`	`return`
`738`	`738`	`thd->killed \|\|`
`739`		`- thd->is_fatal_error \|\|`
`740`	`739`	`thd->is_error() \|\|`
`741`	`740`	`alloced_sel_args > SEL_ARG::MAX_SEL_ARGS;`
`742`	`741`	`}`