MDEV-22690 MSAN use-of-uninitialized-value in optimizer_trace

dr-m · dr-m · commit 1a4846dedc7e · 2020-07-01T16:11:58.000+03:00
This was actually fixed in commit e843033 and all that we need to do is to remove an unnecessary work-around.
diff --git a/sql/my_json_writer.cc b/sql/my_json_writer.cc
@@ -180,9 +180,6 @@ void Json_writer::add_size(longlong val)
 void Json_writer::add_double(double val)
 {
   char buf[64];
-#if __has_feature(memory_sanitizer)  // FIXME: remove this workaround for
-  __msan_unpoison(&val, sizeof val); // main.range_mrr_icp & many other tests
-#endif
   size_t len= my_snprintf(buf, sizeof(buf), "%-.11lg", val);
   add_unquoted_str(buf, len);
 }

Original file line number	Diff line number	Diff line change
`@@ -180,9 +180,6 @@ void Json_writer::add_size(longlong val)`
`180`	`180`	`void Json_writer::add_double(double val)`
`181`	`181`	`{`
`182`	`182`	`char buf[64];`
`183`		`-#if __has_feature(memory_sanitizer) // FIXME: remove this workaround for`
`184`		`- __msan_unpoison(&val, sizeof val); // main.range_mrr_icp & many other tests`
`185`		`-#endif`
`186`	`183`	`size_t len= my_snprintf(buf, sizeof(buf), "%-.11lg", val);`
`187`	`184`	`add_unquoted_str(buf, len);`
`188`	`185`	`}`