Skip to content

Commit 1d2458f

Browse files
committed
MDEV-21024: Clean up rtr_adjust_upper_level()
Remove the unnecessary retrieval and null-modifications of the preceding page.
1 parent cbf5f6d commit 1d2458f

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

storage/innobase/gis/gis0rtree.cc

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,6 @@ rtr_adjust_upper_level(
649649
mem_heap_t* heap;
650650
ulint level;
651651
dtuple_t* node_ptr_upper;
652-
ulint prev_page_no;
653652
ulint next_page_no;
654653
ulint space;
655654
page_cur_t* page_cursor;
@@ -760,28 +759,10 @@ rtr_adjust_upper_level(
760759
mem_heap_free(heap);
761760

762761
/* Get the previous and next pages of page */
763-
prev_page_no = btr_page_get_prev(page, mtr);
764762
next_page_no = btr_page_get_next(page, mtr);
765763
space = block->page.id.space();
766764
const page_size_t& page_size = dict_table_page_size(index->table);
767765

768-
/* Update page links of the level */
769-
if (prev_page_no != FIL_NULL) {
770-
page_id_t prev_page_id(space, prev_page_no);
771-
772-
buf_block_t* prev_block = btr_block_get(
773-
prev_page_id, page_size, RW_X_LATCH, index, mtr);
774-
#ifdef UNIV_BTR_DEBUG
775-
ut_a(page_is_comp(prev_block->frame) == page_is_comp(page));
776-
ut_a(btr_page_get_next(prev_block->frame, mtr)
777-
== block->page.id.page_no());
778-
#endif /* UNIV_BTR_DEBUG */
779-
780-
btr_page_set_next(buf_block_get_frame(prev_block),
781-
buf_block_get_page_zip(prev_block),
782-
page_no, mtr);
783-
}
784-
785766
if (next_page_no != FIL_NULL) {
786767
page_id_t next_page_id(space, next_page_no);
787768

@@ -798,7 +779,6 @@ rtr_adjust_upper_level(
798779
new_page_no, mtr);
799780
}
800781

801-
btr_page_set_prev(page, page_zip, prev_page_no, mtr);
802782
btr_page_set_next(page, page_zip, new_page_no, mtr);
803783

804784
btr_page_set_prev(new_page, new_page_zip, page_no, mtr);

0 commit comments

Comments
 (0)