MDEV-32291 memory leak in innodb.insert_into_empty test

Thirunarayanan · Thirunarayanan · commit 213b916aea47 · 2023-10-02T15:30:33.000+05:30
- This failure happens due to commit bf3b787 (MDEV-31835). InnoDB fails to apply buffered insert operation for transaction_registry during commit operation. To avoid this, ha_commit_trans() should call extra() with HA_EXTRA_RESET_STATE to apply bulk buffered insert operation.
diff --git a/sql/handler.cc b/sql/handler.cc
@@ -1804,6 +1804,7 @@ int ha_commit_trans(THD *thd, bool all)
         (void) trans_rollback_stmt(thd);
         goto err;
       }
+      trt.table->file->extra(HA_EXTRA_RESET_STATE);
       // Here, the call will not commit inside InnoDB. It is only working
       // around closing thd->transaction.stmt open by TR_table::open().
       if (all)

Original file line number	Diff line number	Diff line change
`@@ -1804,6 +1804,7 @@ int ha_commit_trans(THD *thd, bool all)`
`1804`	`1804`	`(void) trans_rollback_stmt(thd);`
`1805`	`1805`	`goto err;`
`1806`	`1806`	`}`
	`1807`	`+ trt.table->file->extra(HA_EXTRA_RESET_STATE);`
`1807`	`1808`	`// Here, the call will not commit inside InnoDB. It is only working`
`1808`	`1809`	`// around closing thd->transaction.stmt open by TR_table::open().`
`1809`	`1810`	`if (all)`