Skip to content

Commit 232af0c

Browse files
committed
Do not disable --symbolic-links on Valgrind (or MSAN)
The option --symbolic-links was originally disabled by default under Purify (and later Valgrind) in 51156c5 without any explanation.
1 parent c009ce7 commit 232af0c

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

mysql-test/main/symlink-myisam-11902.test

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,8 @@ flush tables;
5656
drop table if exists t1;
5757
exec rm -r $MYSQLTEST_VARDIR/tmp/foo;
5858

59+
# Under Valgrind, this could display a warning ER_FILE_NOT_FOUND
60+
--disable_warnings
5961
drop table mysql.t1;
62+
--enable_warnings
6063
set debug_sync='RESET';

sql/mysqld.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6729,7 +6729,7 @@ struct my_option my_long_options[]=
67296729
Also disable by default on Windows, due to high overhead for checking .sym
67306730
files.
67316731
*/
6732-
IF_VALGRIND(0,IF_WIN(0,1)), 0, 0, 0, 0, 0},
6732+
IF_WIN(0,1), 0, 0, 0, 0, 0},
67336733
{"sysdate-is-now", 0,
67346734
"Non-default option to alias SYSDATE() to NOW() to make it safe-replicable. "
67356735
"Since 5.0, SYSDATE() returns a `dynamic' value different for different "

0 commit comments

Comments
 (0)