Skip to content

Commit 31031a5

Browse files
committed
MDEV-11870 Message "MariaDB Galera and flashback does not support"
Fixed the typo, updated result file and suppression in the test file which did not work anyway
1 parent beeacd2 commit 31031a5

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

mysql-test/suite/wsrep/r/binlog_format.result

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
call mtr.add_suppression("WSREP: MariaDB Galera does not support binlog format.*");
1+
call mtr.add_suppression("WSREP: MariaDB Galera and flashback do not support binlog format.*");
22
call mtr.add_suppression("WSREP: Cannot get fake transaction ID from storage engine.");
33
#
44
# MDEV-4227: Galera server should stop crashing on setting binlog_format STATEMENT
@@ -8,20 +8,20 @@ Variable_name Value
88
binlog_format ROW
99
SET binlog_format=STATEMENT;
1010
Warnings:
11-
Warning 1105 MariaDB Galera and flashback does not support binlog format: STATEMENT
11+
Warning 1105 MariaDB Galera and flashback do not support binlog format: STATEMENT
1212
SHOW WARNINGS;
1313
Level Code Message
14-
Warning 1105 MariaDB Galera and flashback does not support binlog format: STATEMENT
14+
Warning 1105 MariaDB Galera and flashback do not support binlog format: STATEMENT
1515
SHOW VARIABLES LIKE 'binlog_format';
1616
Variable_name Value
1717
binlog_format STATEMENT
1818
CREATE TABLE IF NOT EXISTS test.t1 AS SELECT * FROM information_schema.routines WHERE 1 = 0;
1919
SET binlog_format=MIXED;
2020
Warnings:
21-
Warning 1105 MariaDB Galera and flashback does not support binlog format: MIXED
21+
Warning 1105 MariaDB Galera and flashback do not support binlog format: MIXED
2222
SHOW WARNINGS;
2323
Level Code Message
24-
Warning 1105 MariaDB Galera and flashback does not support binlog format: MIXED
24+
Warning 1105 MariaDB Galera and flashback do not support binlog format: MIXED
2525
SHOW VARIABLES LIKE 'binlog_format';
2626
Variable_name Value
2727
binlog_format MIXED

mysql-test/suite/wsrep/t/binlog_format.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
--source include/have_wsrep_provider.inc
22
--source include/have_binlog_format_row.inc
33

4-
call mtr.add_suppression("WSREP: MariaDB Galera does not support binlog format.*");
4+
call mtr.add_suppression("WSREP: MariaDB Galera and flashback do not support binlog format.*");
55
call mtr.add_suppression("WSREP: Cannot get fake transaction ID from storage engine.");
66

77
--echo #

sql/sys_vars.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -454,12 +454,12 @@ static bool binlog_format_check(sys_var *self, THD *thd, set_var *var)
454454
{
455455
// Push a warning to the error log.
456456
push_warning_printf(thd, Sql_condition::WARN_LEVEL_WARN, ER_UNKNOWN_ERROR,
457-
"MariaDB Galera and flashback does not support binlog format: %s",
457+
"MariaDB Galera and flashback do not support binlog format: %s",
458458
binlog_format_names[var->save_result.ulonglong_value]);
459459

460460
if (var->type == OPT_GLOBAL)
461461
{
462-
WSREP_ERROR("MariaDB Galera and flashback does not support binlog format: %s",
462+
WSREP_ERROR("MariaDB Galera and flashback do not support binlog format: %s",
463463
binlog_format_names[var->save_result.ulonglong_value]);
464464
return true;
465465
}

0 commit comments

Comments
 (0)