MDEV-37049 my_assume_aligned assertion in mariabackup

dr-m · dr-m · commit 32128ab65625 · 2025-06-23T08:38:56.000+03:00
log_hdr_buf: Align to an 8-byte boundary, because we will actually assume at least 4-byte alignment in log_crypt_write_header(). This fixes a regression that had been introduced in commit 685d958 (MDEV-14425) where a 512-byte alignment requirement was relaxed too much.
diff --git a/extra/mariabackup/xtrabackup.cc b/extra/mariabackup/xtrabackup.cc
@@ -2593,6 +2593,7 @@ static bool innodb_init_param()
 	return true;
 }
 
+alignas(8)
 static byte log_hdr_buf[log_t::START_OFFSET + SIZE_OF_FILE_CHECKPOINT];
 
 /** Initialize an InnoDB log file header in log_hdr_buf[] */

Original file line number	Diff line number	Diff line change
`@@ -2593,6 +2593,7 @@ static bool innodb_init_param()`
`2593`	`2593`	`return true;`
`2594`	`2594`	`}`
`2595`	`2595`
	`2596`	`+alignas(8)`
`2596`	`2597`	`static byte log_hdr_buf[log_t::START_OFFSET + SIZE_OF_FILE_CHECKPOINT];`
`2597`	`2598`
`2598`	`2599`	`/** Initialize an InnoDB log file header in log_hdr_buf[] */`