Skip to content

Commit 340d93a

Browse files
committed
cleanup: rpl.rpl_semi_sync_shutdown_await_ack
avoid using multiple files with the same functionality.
1 parent e5c9904 commit 340d93a

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

mysql-test/suite/rpl/r/rpl_semi_sync_shutdown_await_ack.result

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -505,8 +505,8 @@ disconnect con1;
505505
connection default;
506506
connection con2;
507507
SHUTDOWN WAIT FOR ALL SLAVES;
508-
connection server_2;
509-
include/assert_grep.inc [Ensure the primary waited for the ACK of the killed thread]
508+
# Ensure the primary waited for the ACK of the killed thread
509+
FOUND 5 /Delaying shutdown to await semi-sync ACK/ in mysqld.1.err
510510
connection default;
511511
connection server_1;
512512
connection server_2;

mysql-test/suite/rpl/t/rpl_semi_sync_shutdown_await_ack.test

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,6 @@ SET GLOBAL debug_dbug="+d,simulate_delay_semisync_slave_reply";
206206
--echo # Wait for thd to begin semi-sync wait..
207207
--let $wait_condition= SELECT COUNT(*) = 1 FROM information_schema.processlist WHERE state = 'Waiting for semi-sync ACK from slave'
208208
--source include/wait_condition.inc
209-
--source include/wait_condition.inc
210209
--echo # ..done
211210

212211
--disconnect con1
@@ -220,15 +219,10 @@ EOF
220219
SHUTDOWN WAIT FOR ALL SLAVES;
221220
--source include/wait_until_disconnected.inc
222221

223-
# Run assert_grep on server_2 as it uses SQL commands for verification, but
224-
# server_1 has gone away
225-
--connection server_2
226-
--let $assert_text= Ensure the primary waited for the ACK of the killed thread
227-
--let $assert_select= Delaying shutdown to await semi-sync ACK
228-
--let $assert_file= $MYSQLTEST_VARDIR/log/mysqld.1.err
229-
--let $assert_count= 5
230-
--let $assert_only_after=CURRENT_TEST
231-
--source include/assert_grep.inc
222+
--echo # Ensure the primary waited for the ACK of the killed thread
223+
--let $SEARCH_PATTERN= Delaying shutdown to await semi-sync ACK
224+
--let $SEARCH_FILE= $MYSQLTEST_VARDIR/log/mysqld.1.err
225+
--source include/search_pattern_in_file.inc
232226

233227
--connection default
234228
--source include/wait_until_disconnected.inc

0 commit comments

Comments
 (0)