MDEV-13550 Copy ctor instread of memcpy() in partition_info::get_clone() (#436)

midenok · vuvova · commit 37dd3cf424d7 · 2017-11-22T12:52:16.000+01:00
List&lt;&gt;::last is wrong after memcpy(). Doing it on constructed objects is bad practice.
diff --git a/sql/partition_info.cc b/sql/partition_info.cc
@@ -42,13 +42,12 @@ partition_info *partition_info::get_clone(THD *thd)
 
   List_iterator<partition_element> part_it(partitions);
   partition_element *part;
-  partition_info *clone= new (mem_root) partition_info();
+  partition_info *clone= new (mem_root) partition_info(*this);
   if (!clone)
   {
     mem_alloc_error(sizeof(partition_info));
     DBUG_RETURN(NULL);
   }
-  memcpy(clone, this, sizeof(partition_info));
   memset(&(clone->read_partitions), 0, sizeof(clone->read_partitions));
   memset(&(clone->lock_partitions), 0, sizeof(clone->lock_partitions));
   clone->bitmaps_are_initialized= FALSE;

Original file line number	Diff line number	Diff line change
`@@ -42,13 +42,12 @@ partition_info partition_info::get_clone(THD thd)`
`42`	`42`
`43`	`43`	`List_iterator<partition_element> part_it(partitions);`
`44`	`44`	`partition_element *part;`
`45`		`- partition_info *clone= new (mem_root) partition_info();`
	`45`	`+ partition_info clone= new (mem_root) partition_info(this);`
`46`	`46`	`if (!clone)`
`47`	`47`	`{`
`48`	`48`	`mem_alloc_error(sizeof(partition_info));`
`49`	`49`	`DBUG_RETURN(NULL);`
`50`	`50`	`}`
`51`		`- memcpy(clone, this, sizeof(partition_info));`
`52`	`51`	`memset(&(clone->read_partitions), 0, sizeof(clone->read_partitions));`
`53`	`52`	`memset(&(clone->lock_partitions), 0, sizeof(clone->lock_partitions));`
`54`	`53`	`clone->bitmaps_are_initialized= FALSE;`