MDEV-33957 UPDATE fails on replica replicating blob virtual column in NOBLOB mode when replica logging is off

The sequence that causes the issue:

1. file->row_logging is false because slave-bin was not open;
2. TABLE::mark_columns_per_binlog_row_image() didn't mark column for
   read because file->row_logginbg is false. This was implemented in
   e53ad95 (MDEV-6877);
3. TABLE::update_virtual_fields() didn't update virtual field value
   because column is not marked for read;
4. calc_row_difference() sees o_len as UNIV_SQL_NULL, but new row
   value is "1". The virtual column is added to update vector;
5. row_upd() tries to update secondary index, but row_upd_sec_step()
   doesn't see old value in the index.

The patch does mark_virtual_column_with_deps() via
column_bitmaps_signal() in case of rgi_slave in
mark_columns_per_binlog_row_image() so that non-stored virtual columns
are marked for update in slave thread.

Also fixed column_bitmaps_signal() for partitioning where the signal
did not reach the partition storage engine.

Author: midenok

mysql-test/suite/rpl/r/rbr_lsu_off.result

@@ -0,0 +1,34 @@
+include/master-slave.inc
+[connection master]
+#
+# MDEV-33957 UPDATE fails on replica replicating blob virtual column in
+#            NOBLOB mode when replica logging is off
+#
+connection slave;
+select @@log_slave_updates;
+@@log_slave_updates
+0
+connection master;
+set binlog_row_image= 'NOBLOB';
+create table t (
+c int primary key, d int,
+i blob generated always as (c), key k(i)) engine=innodb;
+Warnings:
+Note	1071	Specified key was too long; max key length is 3072 bytes
+insert into t (c) values (1);
+update t set d= 0;
+connection slave;
+connection master;
+drop table t;
+create table t (
+c int primary key, d int,
+i blob generated always as (c), key k(i)) engine=innodb
+partition by key (c) partitions 2;
+Warnings:
+Note	1071	Specified key was too long; max key length is 3072 bytes
+insert into t (c) values (1);
+update t set d= 0;
+connection slave;
+connection master;
+drop table t;
+include/rpl_end.inc

mysql-test/suite/rpl/t/rbr_lsu_off-slave.opt

@@ -0,0 +1,2 @@
+--log-slave-updates=0
+

mysql-test/suite/rpl/t/rbr_lsu_off.test

@@ -0,0 +1,35 @@
+--source include/have_innodb.inc
+--source include/have_partition.inc
+--source include/have_binlog_format_row.inc
+--source include/master-slave.inc
+
+--echo #
+--echo # MDEV-33957 UPDATE fails on replica replicating blob virtual column in
+--echo #            NOBLOB mode when replica logging is off
+--echo #
+
+--connection slave
+select @@log_slave_updates;
+--connection master
+set binlog_row_image= 'NOBLOB';
+create table t (
+  c int primary key, d int,
+  i blob generated always as (c), key k(i)) engine=innodb;
+insert into t (c) values (1);
+update t set d= 0;
+--sync_slave_with_master
+
+--connection master
+drop table t;
+create table t (
+  c int primary key, d int,
+  i blob generated always as (c), key k(i)) engine=innodb
+  partition by key (c) partitions 2;
+insert into t (c) values (1);
+update t set d= 0;
+--sync_slave_with_master
+
+--connection master
+drop table t;
+
+--source include/rpl_end.inc

sql/ha_partition.h

@@ -576,6 +576,17 @@ class ha_partition final :public handler
   {
     m_file[part_id]->update_create_info(create_info);
   }
+
+  void column_bitmaps_signal() override
+  {
+    for (uint i= bitmap_get_first_set(&m_opened_partitions);
+        i < m_tot_parts;
+        i= bitmap_get_next_set(&m_opened_partitions, i))
+    {
+      m_file[i]->column_bitmaps_signal();
+    }
+  }
+
 private:
   int copy_partitions(ulonglong * const copied, ulonglong * const deleted);
   void cleanup_new_partition(uint part_count);

sql/table.cc

@@ -7900,7 +7900,8 @@ void TABLE::mark_columns_needed_for_insert()
 }
 
 /*
-  Mark columns according the binlog row image option.
+  Mark columns according the binlog row image option
+  or mark virtual columns for slave.
 
   Columns to be written are stored in 'rpl_write_set'
 
@@ -7931,6 +7932,10 @@ void TABLE::mark_columns_needed_for_insert()
   the read_set at binlogging time (for those cases that
   we only want to log a PK and we needed other fields for
   execution).
+
+  If binlog row image is off on slave we mark virtual columns
+  for read as InnoDB requires correct field metadata which is set
+  by update_virtual_fields().
 */
 
 void TABLE::mark_columns_per_binlog_row_image()
@@ -7940,9 +7945,6 @@ void TABLE::mark_columns_per_binlog_row_image()
   DBUG_ASSERT(read_set->bitmap);
   DBUG_ASSERT(write_set->bitmap);
 
-  /* If not using row format */
-  rpl_write_set= write_set;
-
   /**
     If in RBR we may need to mark some extra columns,
     depending on the binlog-row-image command line argument.
@@ -8018,6 +8020,12 @@ void TABLE::mark_columns_per_binlog_row_image()
     }
     file->column_bitmaps_signal();
   }
+  else
+  {
+    /* If not using row format */
+    rpl_write_set= write_set;
+    file->column_bitmaps_signal();
+  }
 
   DBUG_VOID_RETURN;
 }